Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add Pod 6 to the languages.yml (#4083)" #4148

Merged
merged 1 commit into from
May 30, 2018
Merged

Revert "Add Pod 6 to the languages.yml (#4083)" #4148

merged 1 commit into from
May 30, 2018

Conversation

lildude
Copy link
Member

@lildude lildude commented May 30, 2018

Reverts #4083

As per my comment at #4083 (comment)

Unfortunately, I'm going to have to revert this and open a new PR for it for the moment as it requires Pod 6 rendering support to be implemented in github/markup#1173 or github/markup#1185 and GitHub.com updated. This needs to coincide with the release of a Linguist release that introduces support for Pod 6 so we don't end up leaving people scratching their heads trying to work out why one pod document is being rendered and not another.

I don't currently have the bandwidth to look into the markup side of things either.

... and we need to get a new Linguist release out.

I'll open a new PR to revert this revert once this has been merged. That new PR will be dependent on Pod 6 rendering support being added to markup.

@lildude lildude merged commit e9ad913 into master May 30, 2018
@lildude lildude deleted the lildude/revert-4083 branch May 30, 2018 13:35
lildude added a commit that referenced this pull request May 30, 2018
@lildude
Revert "Revert "Add Pod 6 to the languages.yml (#4083)" (#4148)"
a3cd90d 
This reverts commit e9ad913.
@lildude lildude mentioned this pull request May 30, 2018
Merged
lildude added a commit that referenced this pull request Dec 10, 2018
@lildude
Add Pod 6 to the languages.yml [Pending markup support] (#4149)
972669e 
* Revert "Revert "Add Pod 6 to the languages.yml (#4083)" (#4148)"

This reverts commit e9ad913.

* add .pod6 to Pod 6 extensions

* bump

* remove XPM disambig from .pod
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lildude