Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pod 6 to the languages.yml [Pending markup support] #4149

Merged
merged 6 commits into from
Dec 10, 2018

Conversation

lildude
Copy link
Member

@lildude lildude commented May 30, 2018

This is a revert of the revert in #4148 of #4083 as explained at #4148 (comment):

As per my comment at #4083 (comment)

Unfortunately, I'm going to have to revert this and open a new PR for it for the moment as it requires Pod 6 rendering support to be implemented in github/markup#1173 or github/markup#1185 and GitHub.com updated. This needs to coincide with the release of a Linguist release that introduces support for Pod 6 so we don't end up leaving people scratching their heads trying to work out why one pod document is being rendered and not another.

I don't currently have the bandwidth to look into the markup side of things either.

... and we need to get a new Linguist release out.

I'll open a new PR to revert this revert once this has been merged. That new PR will be dependent on Pod 6 rendering support being added to markup.

This PR can only be merged when markup has support for rendering Pod 6 via github/markup#1173 or github/markup#1185. A combined Linguist and markup update can then be made on GitHub.com to combine the two.

@lildude lildude changed the title Add Pod 6 to the languages.yml Add Pod 6 to the languages.yml [Pending markup support] May 30, 2018
@lildude lildude mentioned this pull request May 30, 2018
@Tyil
Copy link
Contributor

Tyil commented Aug 29, 2018

Any updates on this? Anything that still needs to be done? We're currently a couple months further down the road, and the latest comment we had was that someone else needs to look at it, which seems to have never happened. The latest ping from @JJ in github/markup#1173 got no response either.

@lildude
Copy link
Member Author

lildude commented Aug 29, 2018

Nope. This is still blocked by the markup side of things.

@Tyil
Copy link
Contributor

Tyil commented Aug 29, 2018

I understand that, but we're getting no response in that repository for a couple of months there too.

@kivikakk kivikakk force-pushed the lildude/re-add-4083 branch from db4066e to 17d193b Compare December 10, 2018 00:09
@@ -380,6 +380,16 @@ def call(data)
end
end

disambiguate ".pod" do |data|
if /^\s*\/\* XPM \*\//.match(data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was copied from .pm, but I think isn't necessary for pod.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have removed from heuristics.yml on the tip of this branch. Haven't regenerated a gem for testing because it won't actually come up.

@kivikakk
Copy link
Contributor

Brought up to date.

@lildude
Copy link
Member Author

lildude commented Dec 10, 2018

Thanks @kivikakk. Merging this so chain of PRs can progress.

@lildude lildude merged commit 972669e into master Dec 10, 2018
@lildude lildude deleted the lildude/re-add-4083 branch December 10, 2018 09:03
@JJ
Copy link
Contributor

JJ commented Dec 10, 2018 via email

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants