-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pod 6 to the languages.yml [Pending markup support] #4149
Conversation
Any updates on this? Anything that still needs to be done? We're currently a couple months further down the road, and the latest comment we had was that someone else needs to look at it, which seems to have never happened. The latest ping from @JJ in github/markup#1173 got no response either. |
Nope. This is still blocked by the markup side of things. |
I understand that, but we're getting no response in that repository for a couple of months there too. |
db4066e
to
17d193b
Compare
lib/linguist/heuristics.rb
Outdated
@@ -380,6 +380,16 @@ def call(data) | |||
end | |||
end | |||
|
|||
disambiguate ".pod" do |data| | |||
if /^\s*\/\* XPM \*\//.match(data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was copied from .pm
, but I think isn't necessary for pod.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have removed from heuristics.yml
on the tip of this branch. Haven't regenerated a gem for testing because it won't actually come up.
Brought up to date. |
Thanks @kivikakk. Merging this so chain of PRs can progress. |
Thanks all!
|
This is a revert of the revert in #4148 of #4083 as explained at #4148 (comment):
This PR can only be merged when markup has support for rendering Pod 6 via github/markup#1173 or github/markup#1185. A combined Linguist and markup update can then be made on GitHub.com to combine the two.