-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update script/licensed usage to accommodate upstream changes #4152
Conversation
@lildude The changes look great.
I haven't tested this, but you might be able to remove the custom source entirely and use the example {
...
"vendor/grammars/llvm.tmbundle": "llvm.tmbundle",
"vendor/grammars/m3": "m3",
...
} Maintaining the manifest file would need to happen locally. Looks like that could be done with scripting via a re-mapping of |
@lildude FYI, |
This is looking good now and ready for review. I've updated the licenses whitelist in this PR too as a recent update to licensee has introduced a change that has resulted in a slight variation in the hash for four of the grammars, resulting in all the CI failures that have been occurring in the last 2 weeks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great from the licensed side
Merging to get tests passing again. |
The next version of licensed will cause a breakage in our ability to add grammars, particularly around grabbing the license. This PR fixes that.
Description
licensed changed the method sources are defined in github/licensed#33. As we use a self-defined Filesystem source, we don't get the upstream changes for free so need to make changes ourselves else we'll get failures like this when users attempt to add or update a grammar:
This PR fixes this by slightly modifying and simplifying our self-defined Filesystem source.
This will mean we need to enforce a minimum requirement for Licensed once a new release has been made that includes the changes from github/licensed#33 and github/licensed#41. I'll add this to this PR once the release has been made.
@jonabc do you see any problems with the approach I've taken here? Or maybe we should be changing the method we use entirely so we don't have to do this if licensed changes like this again in future?
Checklist: