-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add interpreter for hy #4158
add interpreter for hy #4158
Conversation
Please note that the hy docs even mention the ussage of shebang in their quickstart. sorry for not stating that stuff in my initial pull request. |
Oh, right! My bad, I should have looked for the You'll need to move the sample file to the |
@pchaigno I am a bit confussed, why exaclty do I need to put the sample file inside also regarding replacing it with something more realistic, I guess a simple fizzbuzz programm should do the job. I'm gonna use that once I have an awnser reagarding its placement inside the repository, if that is okay. |
Oh, wait, you're right (and it's the second time I make that mistake). The sample file is in the right place, and the Travis CI build failure is unrelated to this pull request. |
I hope this sample file is okay. I don't really know what to do about the failed test but yes, they are unrelated (maybe I should have mentioned that...). |
The test failures appear to be caused by recent changes to licensee which has resulted in a slightly modified hash for the four licenses in question. I'll address this in #4152. |
@lildude are any actions on my end needed? like pulling from master or something? |
Yup, you'll need to merge master into your branch to fix the failing tests for a start. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I added a interpreter for hy, which is needed for shebangs to get detected.
Description
The changes are rather simple, I also added a sample file.
I don't think that any of the checkboxes apply here, please correct me if I'm wrong, I am really unsure.
But this pull request doesn't introduce something new, it builds on what is alredy associated with hy.
Checklist:
I am associating a language with a new file extension.
I am adding a new language.
I am fixing a misclassified language
I am changing the source of a syntax highlighting grammar
I am adding new or changing current functionality