Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add interpreter for hy #4158

Merged
merged 3 commits into from
Jul 21, 2018
Merged

add interpreter for hy #4158

merged 3 commits into from
Jul 21, 2018

Conversation

TypicalFence
Copy link
Contributor

I added a interpreter for hy, which is needed for shebangs to get detected.

Description

The changes are rather simple, I also added a sample file.

I don't think that any of the checkboxes apply here, please correct me if I'm wrong, I am really unsure.
But this pull request doesn't introduce something new, it builds on what is alredy associated with hy.

Checklist:

  • I am associating a language with a new file extension.

  • I am adding a new language.

  • I am fixing a misclassified language

    • I have included a new sample for the misclassified language:
      • Sample source(s):
        • [URL to each sample source, if applicable]
      • Sample license(s):
    • I have included a change to the heuristics to distinguish my language from others using the same extension.
  • I am changing the source of a syntax highlighting grammar

  • I am adding new or changing current functionality

    • I have added or updated the tests for the new or changed functionality.

@pchaigno
Copy link
Contributor

pchaigno commented Jun 6, 2018

@lildude There are only 4 users of this shebang. I'm not sure it's worth it...?

@TypicalFence
Copy link
Contributor Author

Please note that the hy docs even mention the ussage of shebang in their quickstart.
Also they use a different one than me, its actually around 600 peoploe.

sorry for not stating that stuff in my initial pull request.

@pchaigno
Copy link
Contributor

pchaigno commented Jun 6, 2018

Also they use a different one than me, its actually around 600 peoploe.

Oh, right! My bad, I should have looked for the /usr/bin/env format.

You'll need to move the sample file to the samples/Hy/filenames/ repository and to replace it with a more realistic one (from the search query for example, though it needs to be under a permissive license).

@TypicalFence
Copy link
Contributor Author

@pchaigno I am a bit confussed, why exaclty do I need to put the sample file inside /samples/Hy/filenames? becuase I just called it hy? couldn't I just rename it?

also regarding replacing it with something more realistic, I guess a simple fizzbuzz programm should do the job. I'm gonna use that once I have an awnser reagarding its placement inside the repository, if that is okay.

@pchaigno
Copy link
Contributor

pchaigno commented Jun 6, 2018

Oh, wait, you're right (and it's the second time I make that mistake). The sample file is in the right place, and the Travis CI build failure is unrelated to this pull request.

@TypicalFence
Copy link
Contributor Author

I hope this sample file is okay.

I don't really know what to do about the failed test but yes, they are unrelated (maybe I should have mentioned that...).

@lildude
Copy link
Member

lildude commented Jun 18, 2018

The test failures appear to be caused by recent changes to licensee which has resulted in a slightly modified hash for the four licenses in question. I'll address this in #4152.

@TypicalFence
Copy link
Contributor Author

@lildude are any actions on my end needed? like pulling from master or something?

@lildude
Copy link
Member

lildude commented Jun 21, 2018

@lildude are any actions on my end needed? like pulling from master or something?

Yup, you'll need to merge master into your branch to fix the failing tests for a start.

Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lildude lildude merged commit 73972dc into github-linguist:master Jul 21, 2018
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants