Check for cached metadata version before comparing it #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where a new dependency's license metadata was not being cached when version metadata for the dependency was not available.
This bug occurs as a result of #21. Previous to that change, licensed only considered reusing cached license data when the cached data existed. A file existence check was removed to optimize for using cached data for more than version checks.
github/linguist
hit an edge case where their license information, which doesn't contain version metadata, began to view non-existent metadata as the same version as new metadata and skipped caching the new content.This PR adds a check that the cached data contains non-nil version metadata before checking if the version metadata is current. Since we can't verify version information that doesn't exist, nil or empty version metadata will force rechecking and caching license content.
/cc @lildude FYI and review as the reporter of the bug