Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary Cargo.toml dependencies via cargo machete #5692

Merged
merged 1 commit into from
May 12, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented May 11, 2024

Connections

Description
Used cargo machete to clean up some unused dependencies. Nothing far reaching and nothing removed completely from the tree but why not, you never know how it helps the build tree!
Added necessary exception instructions to machete so it's smoother the next time someone runs it :)

Testing
it compiles

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@Wumpf Wumpf requested review from a team as code owners May 11, 2024 20:58
@jimblandy jimblandy requested a review from crowlKats May 12, 2024 11:49
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Naga portion looks fine.

Copy link
Collaborator

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deno part seems also good

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔪

@cwfitzgerald cwfitzgerald merged commit 452cf24 into gfx-rs:trunk May 12, 2024
25 checks passed
@Wumpf Wumpf deleted the unused-dependencies branch May 13, 2024 19:25
EriKWDev pushed a commit to bitwise-git/wgpu that referenced this pull request May 14, 2024
jimblandy pushed a commit to jimblandy/wgpu that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants