Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused num-traits dependency of naga #5689

Merged
merged 1 commit into from
May 11, 2024

Conversation

bjorn3
Copy link
Contributor

@bjorn3 bjorn3 commented May 11, 2024

Connections
None

Description
The num-traits dependency of naga is unused. Remove it.

Testing
N/A

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@bjorn3 bjorn3 requested a review from a team May 11, 2024 19:46
@bjorn3 bjorn3 requested a review from a team as a code owner May 11, 2024 19:46
@bjorn3
Copy link
Contributor Author

bjorn3 commented May 11, 2024

I didn't add anything to the changelog as it is a tiny change which can't affect any functionality and I don't know which category to put it in.

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@cwfitzgerald cwfitzgerald merged commit ebbf901 into gfx-rs:trunk May 11, 2024
25 checks passed
@bjorn3 bjorn3 deleted the remove_num_traits branch May 11, 2024 20:32
EriKWDev pushed a commit to bitwise-git/wgpu that referenced this pull request May 14, 2024
jimblandy pushed a commit to jimblandy/wgpu that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants