Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix individual -p wgpu-info builds #5808

Merged

Conversation

ErichDonGubler
Copy link
Member

Connections

#5692 broke cargo check -p wgpu-info et al. ofrick! (CC @Wumpf)

Description

Fix the above by requesting the serde feature from wgpu again.

Testing

Explain how this change is tested.

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@ErichDonGubler ErichDonGubler requested a review from a team as a code owner June 13, 2024 16:11
@ErichDonGubler ErichDonGubler self-assigned this Jun 13, 2024
@ErichDonGubler ErichDonGubler added the area: infrastructure Testing, building, coordinating issues label Jun 13, 2024
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) June 13, 2024 16:22
@cwfitzgerald cwfitzgerald merged commit 39534ff into gfx-rs:trunk Jun 13, 2024
25 checks passed
@ErichDonGubler ErichDonGubler deleted the fix-wgpu_info-feat-sel branch June 13, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: infrastructure Testing, building, coordinating issues
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants