-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating TextureFormat matching specs #2954
Updating TextureFormat matching specs #2954
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'd propose to merge this as soon as possible and do the other work in a separate pr. This is breaking our CI currently. |
Linking Missing TextureFormats #967 |
Linking Texture Format Depth24unormStencil8 not exist in WebGPU #2942 |
Thanks @gents83 for rocking this PR :D |
A few tests seem to fail.
Should DEPTH24PLUS_STENCIL8 be required by default by wgpu? |
It should be ok now- need just a new review from @cwfitzgerald |
Workaround right now is |
Is there any chance to integrate this to fix the web target? |
Just have formatting and a merge conflict and we're g2g |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spec wise looks correct
Fixing compilation error - when doing a full clean:
error[E0599]: no variant or associated item named
Depth24unormStencil8
found for enumGpuTextureFormat
in the current scope--> D:\a\INOX\INOX\extern\wgpu\wgpu\src\backend\web.rs:553:52
|
553 | TextureFormat::Depth24UnormStencil8 => tf::Depth24unormStencil8,
| ^^^^^^^^^^^^^^^^^^^^
| |
| variant or associated item not found in
GpuTextureFormat
| help: there is a variant with a similar name:
Depth24plusStencil8