Shrink the default max binding index to 640 and expose it in Limits. #2957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nical
force-pushed
the
binding-index-640
branch
from
7379235 to
7602ee4
Compare
cwfitzgerald
approved these changes
Aug 13, 2022
nical
force-pushed
the
binding-index-640
branch
from
7602ee4 to
8ec834b
Compare
|
Updated the PR to align with the terminology that made it into the spec. I will get to the web-sys update soon. |
|
@nical @cwfitzgerald I think web-sys 0.3.60 should include Nical's update. |
nical
force-pushed
the
binding-index-640
branch
from
8ec834b to
01f0797
Compare
|
This needs #2954 |
Looks like web-sys makes non-breaking version bumps when there are breaking changes in unstable APIs so sticking to specific versions should avoid unnecessary breakage.
Following the corresponding changes happening in WebGPU.
nical
force-pushed
the
binding-index-640
branch
from
01f0797 to
421b068
Compare
|
This should be good to go. |
jimblandy
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the corresponding changes happening in WebGPU.
Checklist
cargo clippy.web-sysupdatedConnections
Description
The max binding index is reduced to 640 to avoid issues with wgpu's vulkan backend, for which binding indices map directly to the indices in vkCreateDescriptorSetLayout.
640 is the new default limit advertised by the spec, but technically non-vukan backends rename all of the bindings so they aren't affected by the same issue and can continue using 65535 (the previous limit) if requested.
This PR also exposes the limit in
Limits.We don't have to merge this right away since the change has not made it into the WebGPU spec yet.
Testing
None