Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inc984): make mutation condition simpler #6669

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

volokluev
Copy link
Member

We don't need to check this, just rewrite the column

@volokluev volokluev requested a review from a team as a code owner December 13, 2024 03:29
Copy link

codecov bot commented Dec 13, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
1169 1 1168 3
View the top 1 failed tests by shortest run time
tests.manual_jobs.test_scrub_ips_from_spans::test_generate_query
Stack Traces | 0.009s run time
Traceback (most recent call last):
  File ".../tests/manual_jobs/test_scrub_ips_from_spans.py", line 84, in test_generate_query
    assert (
AssertionError: assert ('ALTER TABLE spans_local\n'\n '\n'\n "UPDATE `sentry_tags.value` = arrayMap((k, v) -> if(k = 'user.ip', "\n "'scrubbed', v), `sentry_tags.key`, `sentry_tags.value`)\n"\n 'WHERE project_id IN [1,3,5,6]\n'\n "AND end_timestamp > toDateTime('2024-12-01T00:00:00')\n"\n "AND end_timestamp <= toDateTime('2024-12-10T00:00:00')") == ('ALTER TABLE spans_local\n'\n '\n'\n "UPDATE `sentry_tags.value` = arrayMap((k, v) -> if(k = 'user.ip', "\n "'scrubbed', v), `sentry_tags.key`, `sentry_tags.value`)\n"\n 'WHERE project_id IN [1,3,5,6]\n'\n "AND has(`sentry_tags.key`, 'user.ip')\n"\n "AND end_timestamp > toDateTime('2024-12-01T00:00:00')\n"\n "AND end_timestamp <= toDateTime('2024-12-10T00:00:00')")
    ALTER TABLE spans_local
    
    UPDATE `sentry_tags.value` = arrayMap((k, v) -> if(k = 'user.ip', 'scrubbed', v), `sentry_tags.key`, `sentry_tags.value`)
    WHERE project_id IN [1,3,5,6]
  - AND has(`sentry_tags.key`, 'user.ip')
    AND end_timestamp > toDateTime('2024-12-01T00:00:00')
    AND end_timestamp <= toDateTime('2024-12-10T00:00:00')

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@volokluev volokluev merged commit a20ab86 into master Dec 13, 2024
31 checks passed
@volokluev volokluev deleted the volo/inc984/simpler_update branch December 13, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants