Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inc984): make mutation condition simpler #6669

Merged
merged 2 commits into from
Dec 13, 2024
Merged

feat(inc984): make mutation condition simpler #6669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d563235
make mutation condition simpler
volokluev Dec 13, 2024
89f565b
update tests
volokluev Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion snuba/manual_jobs/scrub_ips_from_spans.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ def _get_query(self, cluster_name: str | None) -> str:
{on_cluster}
UPDATE `sentry_tags.value` = arrayMap((k, v) -> if(k = 'user.ip', 'scrubbed', v), `sentry_tags.key`, `sentry_tags.value`)
WHERE project_id IN [{project_ids}]
AND has(`sentry_tags.key`, 'user.ip')
AND end_timestamp > toDateTime('{start_datetime}')
AND end_timestamp <= toDateTime('{end_datetime}')"""

Expand Down
2 changes: 0 additions & 2 deletions tests/manual_jobs/test_scrub_ips_from_spans.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ def test_generate_query() -> None:

UPDATE `sentry_tags.value` = arrayMap((k, v) -> if(k = 'user.ip', 'scrubbed', v), `sentry_tags.key`, `sentry_tags.value`)
WHERE project_id IN [1,3,5,6]
AND has(`sentry_tags.key`, 'user.ip')
AND end_timestamp > toDateTime('2024-12-01T00:00:00')
AND end_timestamp <= toDateTime('2024-12-10T00:00:00')"""
)
Expand All @@ -98,7 +97,6 @@ def test_generate_query() -> None:
ON CLUSTER 'snuba-spans'
UPDATE `sentry_tags.value` = arrayMap((k, v) -> if(k = 'user.ip', 'scrubbed', v), `sentry_tags.key`, `sentry_tags.value`)
WHERE project_id IN [1,3,5,6]
AND has(`sentry_tags.key`, 'user.ip')
AND end_timestamp > toDateTime('2024-12-01T00:00:00')
AND end_timestamp <= toDateTime('2024-12-10T00:00:00')"""
)
Loading