feat(inc984): make mutation condition simpler (#6669)

We don't need to check this, just rewrite the column
getsentry · Dec 13, 2024 · a20ab86 · a20ab86
1 parent 5ba1ef5
commit a20ab86
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 3 deletions.
diff --git a/snuba/manual_jobs/scrub_ips_from_spans.py b/snuba/manual_jobs/scrub_ips_from_spans.py
@@ -28,7 +28,6 @@ def _get_query(self, cluster_name: str | None) -> str:
 {on_cluster}
 UPDATE `sentry_tags.value` = arrayMap((k, v) -> if(k = 'user.ip', 'scrubbed', v), `sentry_tags.key`, `sentry_tags.value`)
 WHERE project_id IN [{project_ids}]
-AND has(`sentry_tags.key`, 'user.ip')
 AND end_timestamp > toDateTime('{start_datetime}')
 AND end_timestamp <= toDateTime('{end_datetime}')"""
 

diff --git a/tests/manual_jobs/test_scrub_ips_from_spans.py b/tests/manual_jobs/test_scrub_ips_from_spans.py
@@ -87,7 +87,6 @@ def test_generate_query() -> None:
 
 UPDATE `sentry_tags.value` = arrayMap((k, v) -> if(k = 'user.ip', 'scrubbed', v), `sentry_tags.key`, `sentry_tags.value`)
 WHERE project_id IN [1,3,5,6]
-AND has(`sentry_tags.key`, 'user.ip')
 AND end_timestamp > toDateTime('2024-12-01T00:00:00')
 AND end_timestamp <= toDateTime('2024-12-10T00:00:00')"""
     )
@@ -98,7 +97,6 @@ def test_generate_query() -> None:
 ON CLUSTER 'snuba-spans'
 UPDATE `sentry_tags.value` = arrayMap((k, v) -> if(k = 'user.ip', 'scrubbed', v), `sentry_tags.key`, `sentry_tags.value`)
 WHERE project_id IN [1,3,5,6]
-AND has(`sentry_tags.key`, 'user.ip')
 AND end_timestamp > toDateTime('2024-12-01T00:00:00')
 AND end_timestamp <= toDateTime('2024-12-10T00:00:00')"""
     )