Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issue-search): Add group_first_release_id to GroupAttributes processor #5987

Merged
merged 9 commits into from
Jun 11, 2024

Conversation

snigdhas
Copy link
Member

Non-migration changes corresponding to #5986

Copy link

codecov bot commented May 30, 2024

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 232 tests with 1 failed, 231 passed and 0 skipped.

View the full list of failed tests
Test Description Failure message
Testsuite:
pytest

Test name:
tests.test_group_attributes_api.TestGroupAttributesSnQLApi::test_endpoint

Envs:
- default
Traceback (most recent call last):
File ".../snuba/tests/test_group_attributes_api.py", line 99, in test_endpoint
self.insert_row(attribute_message())
File ".../snuba/tests/test_group_attributes_api.py", line 75, in insert_row
write_processed_messages(self.writable_storage, [processed])
File ".../snuba/tests/helpers.py", line 29, in write_processed_messages
).write(rows)
^^^^^^^^^^^
File ".../snuba/snuba/writer.py", line 31, in write
return self.__writer.write(map(self.__encoder.encode, values))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File ".../snuba/clickhouse/http.py", line 359, in write
batch.join(timeout=batch_join_timeout)
File ".../snuba/clickhouse/http.py", line 282, in join
raise ClickhouseWriterError(message, code=code, row=row)
snuba.clickhouse.errors.ClickhouseWriterError: Unknown field found while parsing JSONEachRow format: group_first_release_id: (at row 1)

@snigdhas snigdhas marked this pull request as ready for review May 30, 2024 20:24
@snigdhas snigdhas requested review from a team as code owners May 30, 2024 20:24
Copy link
Member

@evanh evanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a test, you changed the type from UInt8 to UUID but didn't need to change the processor? Something is not right here.

@snigdhas snigdhas requested a review from evanh June 7, 2024 22:26
@snigdhas snigdhas enabled auto-merge (squash) June 10, 2024 22:35
@snigdhas snigdhas merged commit 43a99f1 into master Jun 11, 2024
30 checks passed
@snigdhas snigdhas deleted the snigdha/add-first-release branch June 11, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants