Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issue-search): Add group_first_release_id to GroupAttributes processor #5987

Merged
merged 9 commits into from
Jun 11, 2024
Merged

feat(issue-search): Add group_first_release_id to GroupAttributes processor #5987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ed281f8
Add group_first_release_id to the group_attributes table
snigdhas May 30, 2024
44df1c5
Add group_first_release_id to group_attributes
snigdhas May 30, 2024
a0bc6df
Update type to UUID
snigdhas Jun 6, 2024
bdcd698
Merge branch 'master' into snigdha/add-first-release
snigdhas Jun 7, 2024
915efc1
Add new fields to test
snigdhas Jun 7, 2024
72d160e
style(lint): Auto commit lint changes
getsantry[bot] Jun 7, 2024
884fa18
Fix test import and add UUID processor
snigdhas Jun 7, 2024
13ab333
style(lint): Auto commit lint changes
getsantry[bot] Jun 7, 2024
7bb88c5
Remove processor from entities/
snigdhas Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions snuba/datasets/configuration/group_attributes/entities/group_attributes.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ schema:
{ name: group_status, type: UInt, args: { size: 8 } },
{ name: group_substatus, type: UInt, args: { size: 8, schema_modifiers: [ nullable ] } },
{ name: group_priority, type: UInt, args: { size: 8, schema_modifiers: [ nullable ] } },
{ name: group_first_release_id, type: UUID, args: { schema_modifiers: [ nullable ] } },
{ name: group_first_seen, type: DateTime },
{ name: group_num_comments, type: UInt, args: { size: 64 } },

Expand Down
4 changes: 4 additions & 0 deletions snuba/datasets/configuration/group_attributes/storages/group_attributes.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ schema:
{ name: group_status, type: UInt, args: { size: 8 } },
{ name: group_substatus, type: UInt, args: { size: 8, schema_modifiers: [ nullable ] } },
{ name: group_priority, type: UInt, args: { size: 8, schema_modifiers: [ nullable ] } },
{ name: group_first_release_id, type: UUID, args: { schema_modifiers: [ nullable ] } },
{ name: group_first_seen, type: DateTime },
{ name: group_num_comments, type: UInt, args: { size: 64 } },

Expand Down Expand Up @@ -58,6 +59,9 @@ allocation_policies:
query_processors:
- processor: TableRateLimit
- processor: ConsistencyEnforcerProcessor
- processor: UUIDColumnProcessor
args:
columns: [group_first_release_id]

mandatory_condition_checkers:
- condition: ProjectIdEnforcer
Expand Down
1 change: 1 addition & 0 deletions snuba/datasets/processors/group_attributes_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ def process_message(
"group_status": message["status"],
"group_substatus": message["substatus"],
"group_priority": message.get("priority", None),
"group_first_release_id": message.get("first_release_id", None),
"group_first_seen": datetime.strptime(
message["first_seen"], settings.PAYLOAD_DATETIME_FORMAT
),
Expand Down
7 changes: 7 additions & 0 deletions tests/datasets/test_group_attributes_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import uuid
from datetime import datetime
from typing import Optional

Expand All @@ -14,6 +15,8 @@
from snuba.processor import ProcessedMessage
from snuba.writer import WriterTableRow

RELEASE_ID = uuid.uuid4()


@pytest.fixture
def group_created() -> GroupAttributesSnapshot:
Expand All @@ -23,6 +26,8 @@ def group_created() -> GroupAttributesSnapshot:
"group_id": 1,
"status": 0,
"substatus": 7,
"priority": 25,
"first_release_id": RELEASE_ID,
"first_seen": "2023-02-27T15:40:12.223000Z",
"num_comments": 0,
"assignee_user_id": None,
Expand Down Expand Up @@ -59,6 +64,8 @@ def test_group_created(self, group_created):
"group_id": 1,
"group_status": 0,
"group_substatus": 7,
"group_priority": 25,
"group_first_release_id": RELEASE_ID,
"group_first_seen": datetime.strptime(
group_created["first_seen"], settings.PAYLOAD_DATETIME_FORMAT
),
Expand Down
Loading