-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(issue-search): Add group_first_release_id to the GroupAttributes table #5986
Conversation
This PR has a migration; here is the generated SQL -- start migrations
-- forward migration group_attributes : 0003_add_first_release_id_to_group_attributes
Local op: ALTER TABLE group_attributes_local ADD COLUMN IF NOT EXISTS group_first_release_id Nullable(UUID) AFTER group_priority;
Distributed op: ALTER TABLE group_attributes_dist ADD COLUMN IF NOT EXISTS group_first_release_id Nullable(UUID) AFTER group_priority;
-- end forward migration group_attributes : 0003_add_first_release_id_to_group_attributes
-- backward migration group_attributes : 0003_add_first_release_id_to_group_attributes
Distributed op: ALTER TABLE group_attributes_dist DROP COLUMN IF EXISTS group_first_release_id;
Local op: ALTER TABLE group_attributes_local DROP COLUMN IF EXISTS group_first_release_id;
-- end backward migration group_attributes : 0003_add_first_release_id_to_group_attributes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. first_release_id
also exists on GroupEnvironment
, are we also planning to replicate that somehow?
storage_set=StorageSetKey.GROUP_ATTRIBUTES, | ||
table_name="group_attributes_local", | ||
column=Column( | ||
"group_first_release_id", UInt(8, Modifiers(nullable=True)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question, is this actually a full release ID? Is that really a UInt8 only? Aren't releases UUIDs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UUID makes sense, thanks
We'll handle |
Add a new column,
group_first_release_id
to the GroupAttributes table. This column will be backfilled as part of the issue search improvements, with data fromGroup.first_release_id
.This column will help speed up searches for
firstRelease
. We'll still handlefirstRelease
queries using Postgres if the query includes the environment.