Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamic-sampling): Add transaction name prioritize option - [TET-681] #45034

Conversation

priscilawebdev
Copy link
Member

@priscilawebdev priscilawebdev commented Feb 23, 2023

This PR introduces a new dynamic sampling "Prioritization" called "Prioritize low-volume transactions". The UI will be hidden behind a feature flag controlled by flagr until we have tested this out.

Preview:

image

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 23, 2023
@priscilawebdev priscilawebdev force-pushed the feat/dynamic-sampling-add-transaction-name-prioritize-option branch from 5ab09bb to d8468d8 Compare February 23, 2023 13:17
@priscilawebdev priscilawebdev changed the base branch from master to andrii/add-toggle-prioritise-by-tx-name February 23, 2023 13:17
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 23, 2023
@github-actions
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2023

🏷 The following changes will be made to the repository labels

Validating provided labels
Fetching labels from GitHub
Labels are already up to date

@priscilawebdev priscilawebdev force-pushed the feat/dynamic-sampling-add-transaction-name-prioritize-option branch from d8468d8 to 0b4710c Compare February 23, 2023 13:18
@priscilawebdev priscilawebdev force-pushed the feat/dynamic-sampling-add-transaction-name-prioritize-option branch from 0b4710c to 0e4ec1f Compare February 23, 2023 13:21
@priscilawebdev priscilawebdev marked this pull request as ready for review February 23, 2023 13:29
@priscilawebdev priscilawebdev requested a review from a team as a code owner February 23, 2023 13:29
@priscilawebdev priscilawebdev removed the Scope: Backend Automatically applied to PRs that change backend components label Feb 23, 2023
Co-authored-by: Andrii Soldatenko <[email protected]>
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
src/sentry/static/sentry/dist/entrypoints/app.js 19.93 KB (+0.02% 🔺)
src/sentry/static/sentry/dist/entrypoints/sentry.css 32.99 KB (0%)

@andriisoldatenko
Copy link
Contributor

BE PR #44944

Base automatically changed from andrii/add-toggle-prioritise-by-tx-name to master February 28, 2023 12:24
@priscilawebdev priscilawebdev enabled auto-merge (squash) February 28, 2023 12:42
@priscilawebdev priscilawebdev merged commit 917286b into master Feb 28, 2023
@priscilawebdev priscilawebdev deleted the feat/dynamic-sampling-add-transaction-name-prioritize-option branch February 28, 2023 13:01
jan-auer added a commit that referenced this pull request Feb 28, 2023
* master: (79 commits)
  feat(perf-issues): Add performance issue detection timing runner command (#44912)
  Revert "chore: Investigating org slug already set to a different value (#45134)"
  fix(hybrid-cloud): Redirect to org restoration page for customer domains (#45159)
  bug(replays): Fix 500 error when marshaling tags field (#45097)
  ref(sourcemaps): Redesign lookup of source and sourcemaps (#45032)
  chore: Investigating org slug already set to a different value (#45134)
  feat(dynamic-sampling): Implement prioritize by project bias [TET-574] (#42939)
  feat(dynamic-sampling): Add transaction name prioritize option - (#45034)
  feat(dyn-sampling): add new bias toggle to project details for prioritise by tx name [TET-717] (#44944)
  feat(admin) Add admin relay project config view [TET-509] (#45120)
  Revert "chore(assignment): Add analytics when autoassigning after a manual assignment (#45099)"
  feat(sourcemaps): Implement new tables supporting debug ids (#44572)
  ref(js): Remove usage of react-document-title (#45170)
  chore(py): Consistently name urls using `organization-` prefix (#45180)
  ref: rename acceptance required checks collector (#45156)
  chore(assignment): Add analytics when autoassigning after a manual assignment (#45099)
  feat(source-maps): Update copy for source map debug alerts (#45164)
  ref(js): Remove custom usage of DocumentTitle (#45165)
  chore(login): update the login banners (#45151)
  ref(py): Remove one more legacy project_id from Environment (#45160)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants