ref(sourcemaps): Redesign lookup of source and sourcemaps #45032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
iambriccardo
changed the title
2 tasks
mitsuhiko
approved these changes
Feb 24, 2023
mitsuhiko
approved these changes
Feb 28, 2023
Swatinem
approved these changes
Feb 28, 2023
There was a problem hiding this comment.
code and comments are a lot more readable!
This also gave me a couple of ideas for symbolicator. CC @kamilogorek @loewenheim just fyi
|
|
||
| # Cache holding the results of the fetching by url. | ||
| self.fetch_by_url_sourceviews = {} | ||
| self.fetch_by_url_errors = {} |
There was a problem hiding this comment.
is this the only place that stores (cached) download errors?
mitsuhiko
approved these changes
Feb 28, 2023
kamilogorek
reviewed
Feb 28, 2023
| self.allow_scraping = allow_scraping | ||
|
|
||
| def bind_release(self, release=None, dist=None): | ||
| """Updates the fetcher with a project, release and dist.""" |
There was a problem hiding this comment.
It doesn't bind the project 👀
There was a problem hiding this comment.
@mitsuhiko what is your excuse? 👀🤣
jan-auer
added a commit
that referenced
this pull request
Feb 28, 2023
* master: (79 commits) feat(perf-issues): Add performance issue detection timing runner command (#44912) Revert "chore: Investigating org slug already set to a different value (#45134)" fix(hybrid-cloud): Redirect to org restoration page for customer domains (#45159) bug(replays): Fix 500 error when marshaling tags field (#45097) ref(sourcemaps): Redesign lookup of source and sourcemaps (#45032) chore: Investigating org slug already set to a different value (#45134) feat(dynamic-sampling): Implement prioritize by project bias [TET-574] (#42939) feat(dynamic-sampling): Add transaction name prioritize option - (#45034) feat(dyn-sampling): add new bias toggle to project details for prioritise by tx name [TET-717] (#44944) feat(admin) Add admin relay project config view [TET-509] (#45120) Revert "chore(assignment): Add analytics when autoassigning after a manual assignment (#45099)" feat(sourcemaps): Implement new tables supporting debug ids (#44572) ref(js): Remove usage of react-document-title (#45170) chore(py): Consistently name urls using `organization-` prefix (#45180) ref: rename acceptance required checks collector (#45156) chore(assignment): Add analytics when autoassigning after a manual assignment (#45099) feat(source-maps): Update copy for source map debug alerts (#45164) ref(js): Remove custom usage of DocumentTitle (#45165) chore(login): update the login banners (#45151) ref(py): Remove one more legacy project_id from Environment (#45160) ...
mitsuhiko
pushed a commit
that referenced
this pull request
Feb 28, 2023
This PR fixes a problem introduced in the redesign PR (#45032), which we overlooked the `self.project` parameter in the `Fetcher`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at implementing a new system for looking up source and sourcemaps files for each frame. This mechanism has been designed to account for the future implementation of debug ids.
#sync-getsentry