feat(dyn-sampling): add new bias toggle to project details for prioritise by tx name [TET-717] #44944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
andriisoldatenko
changed the title
andriisoldatenko
changed the title
andriisoldatenko
changed the title
| @@ -31,6 +31,7 @@ class RuleType(Enum): | |||
| BOOST_LATEST_RELEASES_RULE = "boostLatestRelease" | |||
| IGNORE_HEALTH_CHECKS_RULE = "ignoreHealthChecks" | |||
| BOOST_KEY_TRANSACTIONS_RULE = "boostKeyTransactions" | |||
| PRIORITISE_BY_TX_NAME_RULE = "prioritiseByTxName" | |||
There was a problem hiding this comment.
shall we make this plural to be consistent?
Suggested change
| PRIORITISE_BY_TX_NAME_RULE = "prioritiseByTxName" | |
| PRIORITIZE_BY_TRANSACTION_NAMES_RULE = "prioritizeByTransactionNames" |
There was a problem hiding this comment.
yeah sure we can rename, I had a similar name but then decided to make it shorter.
RaduW
reviewed
Feb 23, 2023
Co-authored-by: Radu Woinaroski <[email protected]>
| @@ -1468,6 +1470,7 @@ def test_put_new_dynamic_sampling_rules_with_correct_flags(self): | |||
| }, | |||
| {"id": "ignoreHealthChecks", "active": False}, | |||
| {"id": "boostKeyTransactions", "active": False}, | |||
| {"id": "prioritiseByTxName", "active": False}, | |||
There was a problem hiding this comment.
Maybe you missed the renaming here.
There was a problem hiding this comment.
fixed in b064f9c
| @@ -1351,6 +1352,7 @@ def test_get_dynamic_sampling_biases_with_previously_assigned_biases(self): | |||
| }, | |||
| {"id": "ignoreHealthChecks", "active": True}, | |||
| {"id": "boostKeyTransactions", "active": True}, | |||
| {"id": "prioritiseByTxName", "active": False}, | |||
There was a problem hiding this comment.
good catch, let me fix it.
There was a problem hiding this comment.
@iambriccardo fixed in b064f9c
andriisoldatenko
requested review from
iambriccardo and
RaduW
and removed request for
iambriccardo
iambriccardo
approved these changes
Feb 27, 2023
|
We would also need a separate PR to update the logging system. |
Please create a ticket with details and I can fix it! |
priscilawebdev
approved these changes
Feb 28, 2023
jan-auer
added a commit
that referenced
this pull request
Feb 28, 2023
* master: (79 commits) feat(perf-issues): Add performance issue detection timing runner command (#44912) Revert "chore: Investigating org slug already set to a different value (#45134)" fix(hybrid-cloud): Redirect to org restoration page for customer domains (#45159) bug(replays): Fix 500 error when marshaling tags field (#45097) ref(sourcemaps): Redesign lookup of source and sourcemaps (#45032) chore: Investigating org slug already set to a different value (#45134) feat(dynamic-sampling): Implement prioritize by project bias [TET-574] (#42939) feat(dynamic-sampling): Add transaction name prioritize option - (#45034) feat(dyn-sampling): add new bias toggle to project details for prioritise by tx name [TET-717] (#44944) feat(admin) Add admin relay project config view [TET-509] (#45120) Revert "chore(assignment): Add analytics when autoassigning after a manual assignment (#45099)" feat(sourcemaps): Implement new tables supporting debug ids (#44572) ref(js): Remove usage of react-document-title (#45170) chore(py): Consistently name urls using `organization-` prefix (#45180) ref: rename acceptance required checks collector (#45156) chore(assignment): Add analytics when autoassigning after a manual assignment (#45099) feat(source-maps): Update copy for source map debug alerts (#45164) ref(js): Remove custom usage of DocumentTitle (#45165) chore(login): update the login banners (#45151) ref(py): Remove one more legacy project_id from Environment (#45160) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new toggle for project details for prioritise by tx name
Tested locally: