-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove performance link from navigation #84021
Comments
DominikB2014
added a commit
that referenced
this issue
Jan 27, 2025
Work for #84021 Corresponding PR getsentry/sentry-options-automator#3058
DominikB2014
added a commit
that referenced
this issue
Jan 29, 2025
…84229) As part of #84021 , we have to update the route for the transaction summary to be `/insights/summary` instead of `/performance/summary`. This route change should be behind a flag. We have a helper function that returns the transaction summary url `getTransactionSummaryBaseUrl`, this function makes the most sense to add the conditional that returns either /insights/summary or /performance/summary. However the helper function does not have access to organization features. This PR replaces the `orgSlug` parameter with the `organization` parameter, that way we can access `organization.features`. In another PR we can use this parameter to add the conditional on the feature flag.
andrewshie-sentry
pushed a commit
that referenced
this issue
Jan 29, 2025
Work for #84021 Corresponding PR getsentry/sentry-options-automator#3058
andrewshie-sentry
pushed a commit
that referenced
this issue
Jan 29, 2025
…84229) As part of #84021 , we have to update the route for the transaction summary to be `/insights/summary` instead of `/performance/summary`. This route change should be behind a flag. We have a helper function that returns the transaction summary url `getTransactionSummaryBaseUrl`, this function makes the most sense to add the conditional that returns either /insights/summary or /performance/summary. However the helper function does not have access to organization features. This PR replaces the `orgSlug` parameter with the `organization` parameter, that way we can access `organization.features`. In another PR we can use this parameter to add the conditional on the feature flag.
c298lee
pushed a commit
that referenced
this issue
Jan 29, 2025
…84229) As part of #84021 , we have to update the route for the transaction summary to be `/insights/summary` instead of `/performance/summary`. This route change should be behind a flag. We have a helper function that returns the transaction summary url `getTransactionSummaryBaseUrl`, this function makes the most sense to add the conditional that returns either /insights/summary or /performance/summary. However the helper function does not have access to organization features. This PR replaces the `orgSlug` parameter with the `organization` parameter, that way we can access `organization.features`. In another PR we can use this parameter to add the conditional on the feature flag.
This was referenced Feb 3, 2025
DominikB2014
added a commit
that referenced
this issue
Feb 6, 2025
Work for #84021 Makes the banner red so that it draws more eyes, will merge this when we have the green light from product. <img width="1261" alt="image" src="https://github.com/user-attachments/assets/093f7219-7ca6-4b77-8f2e-b66e1c34f554" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The domain overview pages have been out for awhile, we should remove remove the old performance landing page link in the sidebar. There is some details about that here https://www.notion.so/sentry/Migrating-away-from-perf-landing-page-1828b10e4b5d804bb74ee89d5a63d486?pvs=4
Navigating to the transaction summary outside a domain view
Performance Landing page
Sidebar
The text was updated successfully, but these errors were encountered: