Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(insights): highlight insights on sidebar when on transaction summary #84699

Merged

Conversation

DominikB2014
Copy link
Contributor

Work for #84021

  1. When you land on a transaction summary page external to a domain view, we should highlight Insights.
image
  1. feat(insights): redirect performance in sidebar to domain view #84117 introduced a bug where both performance and a domain view would highlight (see screenshot below), this PR ensures the redirect introduced in that PR results in only the domain view highlighting
image

@DominikB2014 DominikB2014 requested a review from a team February 6, 2025 16:35
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 6, 2025
@DominikB2014 DominikB2014 merged commit a5937d2 into master Feb 6, 2025
43 checks passed
@DominikB2014 DominikB2014 deleted the DominikB2014/highlight-insights-transaction-summary branch February 6, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants