ref(insights): pass in organization to getTransactionSummaryBaseUrl #84229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
❌ 2 Tests Failed:
View the top 2 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
narsaynorath
approved these changes
Jan 29, 2025
DominikB2014
deleted the
DominikB2014/pass-in-org-for-transaction-summary-route
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 29, 2025
…84229) As part of #84021 , we have to update the route for the transaction summary to be `/insights/summary` instead of `/performance/summary`. This route change should be behind a flag. We have a helper function that returns the transaction summary url `getTransactionSummaryBaseUrl`, this function makes the most sense to add the conditional that returns either /insights/summary or /performance/summary. However the helper function does not have access to organization features. This PR replaces the `orgSlug` parameter with the `organization` parameter, that way we can access `organization.features`. In another PR we can use this parameter to add the conditional on the feature flag.
c298lee
pushed a commit
that referenced
this pull request
Jan 29, 2025
…84229) As part of #84021 , we have to update the route for the transaction summary to be `/insights/summary` instead of `/performance/summary`. This route change should be behind a flag. We have a helper function that returns the transaction summary url `getTransactionSummaryBaseUrl`, this function makes the most sense to add the conditional that returns either /insights/summary or /performance/summary. However the helper function does not have access to organization features. This PR replaces the `orgSlug` parameter with the `organization` parameter, that way we can access `organization.features`. In another PR we can use this parameter to add the conditional on the feature flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #84021 , we have to update the route for the transaction summary to be
/insights/summaryinstead of/performance/summary. This route change should be behind a flag.We have a helper function that returns the transaction summary url
getTransactionSummaryBaseUrl, this function makes the most sense to add the conditional that returns either /insights/summary or /performance/summary. However the helper function does not have access to organization features.This PR replaces the
orgSlugparameter with theorganizationparameter, that way we can accessorganization.features. In another PR we can use this parameter to add the conditional on the feature flag.