-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crons: Add support for multiple environments #42788
Comments
When this feature is added, it would be nice if we could set up alerts for just one environment. For example, I would want to get alerted when it's down for production, but I'm not sure I wouldn't want alerts for other environments. |
Update from the Crons team: We've successfully rolled out support for multiple environments! 🎉 Here are some instructions per platform:
If you have any questions or issues, feel free to reach out to us at [email protected]. Thank you. |
Currently, a Cron Monitor does not support multiple environments such as "production", "development", etc.
Spec from @evanpurkhiser
We'll need to make some data model updates and adjust some assumptions about how monitors currently store status.
Adding environments means that each checkin entry will now be associated to an environment (or the default empty string).
Monitor status can no longer be denormalized onto the
monitor
object. The status needs to come from the most recent checkin for the selected environment(s). The status of the monitor will become dependent on the most recent checkin.Each monitor should have a list of activated environments associated to it. We should introduce a
monitorenvironment
model that has a FK to the monitor and a FK to the project environment.next checkin time needs to move to the environment.
Checkin details should be specific to a single environment. It does not make sense to try and show checkins for a monitor across multiple environments.
When listing monitors we should only allow selection of a single environment.
Checkins must now accept the environment for which the checkin is associated to. (If none is passed it should default to production (see
environment
in the link))The
check_monitors
task now needs to take into account each environment as well, so we'll need to update the query to join on themonitor_environments
table.Tasks
MonitorEnvironment
model #45011check_monitor
task to dual write into monitor environments #45022monitor_index
+monitor_details
endpoint to filter on environment #45019monitor_stats
to filter on environment #45020The text was updated successfully, but these errors were encountered: