feat(crons): Allow specifying checkin environment #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-allow-specifying-checkin-environment
branch
from
9ff503c to
fa588fd
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-allow-specifying-checkin-environment
branch
from
fa588fd to
13b2b61
Compare
kamilogorek
reviewed
May 4, 2023
| @@ -2503,6 +2505,8 @@ pub struct UpdateMonitorCheckIn { | |||
| pub status: Option<MonitorCheckinStatus>, | |||
| #[serde(skip_serializing_if = "Option::is_none")] | |||
| pub duration: Option<u64>, | |||
| #[serde(skip_serializing_if = "Option::is_none")] | |||
| pub environment: Option<String>, | |||
There was a problem hiding this comment.
Why is it Option if we have a default value?
There was a problem hiding this comment.
It's not absolutely required to send, this reflects that should the API be used anywhere else
kamilogorek
approved these changes
May 5, 2023
evanpurkhiser
deleted the
evanpurkhiser/feat-crons-allow-specifying-checkin-environment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1564