Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crons: Remove dual write logic for monitor checkins, leaving only writing to monitor environments #45023

Closed
Tracked by #42788
evanpurkhiser opened this issue Feb 23, 2023 · 6 comments
Closed
Tracked by #42788

Crons: Remove dual write logic for monitor checkins, leaving only writing to monitor environments #45023

evanpurkhiser opened this issue Feb 23, 2023 · 6 comments
Assignees
@rjo100

Comments

@evanpurkhiser
Copy link
Member

This involves moving most of the model logic for monitors into the EnvironmentMonitor model.
@evanpurkhiser evanpurkhiser mentioned this issue Feb 23, 2023
Closed
@getsantry
Copy link
Contributor

getsantry bot commented Apr 3, 2023

Routing to @getsentry/crons for triage, due by Wednesday, April 5th at 1:29 pm (sfo). ⏲️

@evanpurkhiser
Copy link
Member Author

#46973 is going to help with removing some of these legacy fields

@rjo100
Copy link
Contributor

rjo100 commented Apr 26, 2023

Initial removal of references to params we want to remove/modify
#47910

@rjo100
Copy link
Contributor

rjo100 commented Apr 26, 2023

First PR:

  • Stop updating Monitor objects (status, check-in times)
  • Remove check-in times from the Monitor serializer
  • DRAWBACK: Monitor objects will have "dangling" MISSED_CHECKIN\OK\ERROR statuses that won't get updated (and are visible via the API)

Backfill PR:

  • Ensure that all check-ins have an associated monitor environment

Migration PR:

  • Remove null from monitor_environment for check-ins
  • Update Monitor status to revert to ObjectStatus instead of custom MonitorStatus

Long term:

  • Monitor list sorting will need some reworking, but depends on what frontend decides
  • Improve MonitorStatus away from a subclass

@rjo100
Copy link
Contributor

rjo100 commented Apr 26, 2023

Am cutting another PR now to "fix" sorting

@rjo100
Copy link
Contributor

rjo100 commented Apr 26, 2023 •
edited
Loading

#48039 <- sorting

@gaprl gaprl closed this as completed May 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rjo100 rjo100

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gaprl @evanpurkhiser @rjo100