Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Add span.updateName() and deprecate span.setName() #10018

Merged
merged 4 commits into from
Jan 3, 2024
Merged

feat(core): Add span.updateName() and deprecate span.setName() #10018

merged 4 commits into from
Jan 3, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 2, 2024

You can call span.setMetadata() if you need to update the source.

This aligns with the OTEL API for spans.

@mydea mydea requested review from lforst, Lms24 and AbhiPrasad January 2, 2024 16:33
@mydea mydea self-assigned this Jan 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 76.03 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 67.39 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 61.01 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.97 KB (+0.06% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 30.42 KB (0%)
@sentry/browser - Webpack (gzipped) 22.12 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 73.42 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 65.1 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 31.25 KB (+0.04% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 23.16 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 204.23 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 94.11 KB (+0.09% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 68.73 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 34.23 KB (+0.06% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 67.8 KB (+0.03% 🔺)
@sentry/react - Webpack (gzipped) 22.16 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 84.45 KB (+0.03% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 49.07 KB (+0.03% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 16.63 KB (0%)

@mydea mydea force-pushed the fn/spanUpdateName branch 2 times, most recently from dfaabce to 561536e Compare January 3, 2024 09:05
@mydea mydea force-pushed the fn/spanUpdateName branch from 2c2f6cf to 1ce2a63 Compare January 3, 2024 10:18
@mydea mydea force-pushed the fn/spanUpdateName branch from 1ce2a63 to ec4decd Compare January 3, 2024 10:32
@mydea mydea merged commit e5f3428 into develop Jan 3, 2024
95 checks passed
@mydea mydea deleted the fn/spanUpdateName branch January 3, 2024 11:07
anonrig pushed a commit that referenced this pull request Jan 3, 2024
@mydea @anonrig
feat(core): Add span.updateName() and deprecate span.setName() (#…
d026929 
…10018)

You can call `span.setMetadata()` if you need to update the source.

This aligns with the OTEL API for spans.
@Lms24 Lms24 mentioned this pull request Jan 12, 2024
Merged
Lms24 added a commit that referenced this pull request Jan 12, 2024
@Lms24
feat(core): Deprecate remaining setName declarations on `Transactio…
2171633 
…n` and `Span` (#10164)

Seems like we didn't fully deprecate the `setName` API in #10018 as some
deprecation annotations were still missing on
* `Span` class
* `Transaction` class
* `Transaction` interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@lforst lforst Awaiting requested review from lforst

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mydea @Lms24