align with OTEL Api and return this

getsentry · Jan 3, 2024 · 2c2f6cf · 2c2f6cf
1 parent 561536e
commit 2c2f6cf
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/packages/core/src/tracing/span.ts b/packages/core/src/tracing/span.ts
@@ -277,8 +277,9 @@ export class Span implements SpanInterface {
   /**
    * @inheritDoc
    */
-  public updateName(name: string): void {
+  public updateName(name: string): this {
     this.description = name;
+    return this;
   }
 
   /**

diff --git a/packages/core/src/tracing/transaction.ts b/packages/core/src/tracing/transaction.ts
@@ -101,8 +101,9 @@ export class Transaction extends SpanClass implements TransactionInterface {
   }
 
   /** @inheritdoc */
-  public updateName(name: string): void {
+  public updateName(name: string): this {
     this._name = name;
+    return this;
   }
 
   /**

diff --git a/packages/types/src/span.ts b/packages/types/src/span.ts
@@ -212,7 +212,7 @@ export interface Span extends SpanContext {
   /**
    * Update the name of the span.
    */
-  updateName(name: string): void;
+  updateName(name: string): this;
 
   /**
    * Creates a new `Span` while setting the current `Span.id` as `parentSpanId`.