fix tests

getsentry · Jan 3, 2024 · ec4decd · ec4decd
1 parent 2ac913c
commit ec4decd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/packages/sveltekit/test/client/router.test.ts b/packages/sveltekit/test/client/router.test.ts
@@ -27,6 +27,7 @@ describe('sveltekitRoutingInstrumentation', () => {
     returnedTransaction = {
       ...txnCtx,
       updateName: vi.fn(),
+      setMetadata: vi.fn(),
       startChild: vi.fn().mockImplementation(ctx => {
         return { ...mockedRoutingSpan, ...ctx };
       }),

diff --git a/packages/tracing/test/transaction.test.ts b/packages/tracing/test/transaction.test.ts
@@ -63,18 +63,11 @@ describe('`Transaction` class', () => {
     });
 
     describe('`updateName` method', () => {
-      it("sets source to `'custom'` if no source provided", () => {
+      it('does not change the source', () => {
         const transaction = new Transaction({ name: 'dogpark' });
+        transaction.setMetadata({ source: 'route' });
         transaction.updateName('ballpit');
 
-        expect(transaction.name).toEqual('ballpit');
-        expect(transaction.metadata.source).toEqual('custom');
-      });
-
-      it('uses given `source` value', () => {
-        const transaction = new Transaction({ name: 'dogpark' });
-        transaction.updateName('ballpit', 'route');
-
         expect(transaction.name).toEqual('ballpit');
         expect(transaction.metadata.source).toEqual('route');
       });