Get start development without npm #3793
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
reviewed
May 13, 2019
| @@ -13,6 +13,7 @@ services: | |||
| - "5678:5678" | |||
| volumes: | |||
| - ".:/app" | |||
| - "/app/client/dist" | |||
There was a problem hiding this comment.
Won't this break using npm on the host?
There was a problem hiding this comment.
Thank you for your review.
When using npm on the host, I think that npm start or npm run watch on the host.
Should I add a configuration to reflect the changes using npm on host ?
There was a problem hiding this comment.
I meant, wouldn't setting up the volume this way make the changes on the host not seen in the container?
There was a problem hiding this comment.
I see.
I'll update the changes made on the host can appear in the container.
There was a problem hiding this comment.
I'm sorry, I misunderstood.
This Pull Request close.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
upwithout installingnpmPostgrescan save persistently