Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing failure report task #4050

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Conversation

rauchy
Copy link
Contributor

@rauchy rauchy commented Aug 7, 2019

What type of PR is this? (check all applicable)

  • Bug Fix

Description

Following #3797, failures were aggregated, but were not picked up by the send_aggregated_errors task due to variable shadowing. This is fixed in this PR.

Related Tickets & Documents

Related to #3793

@rauchy rauchy requested a review from arikfr August 7, 2019 10:31
@rauchy rauchy merged commit c4dcf01 into master Aug 7, 2019
@rauchy rauchy deleted the fix-failing-failure-report-task branch August 7, 2019 19:43
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants