Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get start development without npm #3793

Closed
wants to merge 3 commits into from
Closed

Get start development without npm #3793

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df1e6cb
enable container data
shunsuke-excite May 9, 2019
1707d94
moidify persistence
shunsuke-excite May 9, 2019
8605355
Merge branch 'master' of https://github.com/getredash/redash
shunsuke-excite May 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ services:
- "5678:5678"
volumes:
- ".:/app"
- "/app/client/dist"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this break using npm on the host?

Copy link
Author

@shunsuke-excite shunsuke-excite May 13, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review.
When using npm on the host, I think that npm start or npm run watch on the host.
Should I add a configuration to reflect the changes using npm on host ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant, wouldn't setting up the volume this way make the changes on the host not seen in the container?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.
I'll update the changes made on the host can appear in the container.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I misunderstood.
This Pull Request close.

environment:
PYTHONUNBUFFERED: 0
REDASH_LOG_LEVEL: "INFO"
Expand All @@ -24,6 +25,7 @@ services:
command: scheduler
volumes:
- ".:/app"
- "/app/client/dist"
depends_on:
- server
environment:
Expand All @@ -45,3 +47,7 @@ services:
- "15432:5432"
command: "postgres -c fsync=off -c full_page_writes=off -c synchronous_commit=OFF"
restart: unless-stopped
volumes:
- dbdata:/var/lib/postgresql/data
volumes:
dbdata: