fix: run code quality on both push, and pull requests #218
You are viewing an older attempt in the history of this workflow run.
View latest attempt.
Annotations
4 errors and 3 warnings
wildcard match will also match any future added variants:
crates/core/src/suppress.rs#L121
error: wildcard match will also match any future added variants
--> crates/core/src/suppress.rs:121:13
|
121 | _ => false,
| ^ help: try: `EitherOrBoth::Left(_) | EitherOrBoth::Right(_)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_enum_match_arm
note: the lint level is defined here
--> crates/core/src/lib.rs:1:9
|
1 | #![deny(clippy::wildcard_enum_match_arm)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
single-character string constant used as pattern:
crates/core/src/suppress.rs#L118
error: single-character string constant used as pattern
--> crates/core/src/suppress.rs:118:33
|
118 | .zip_longest(text.split("\n"))
| ^^^^ help: consider using a `char`: `'\n'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
= note: `-D clippy::single-char-pattern` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::single_char_pattern)]`
|
this loop never actually loops:
crates/core/src/binding.rs#L543
error: this loop never actually loops
--> crates/core/src/binding.rs:543:25
|
543 | / while !done {
544 | | while cursor.field_id() != Some(field_id) {
545 | | if !cursor.goto_next_sibling() {
546 | | return None;
... |
553 | | return Some(result);
554 | | }
| |_________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop
= note: `#[deny(clippy::never_loop)]` on by default
|
clippy_check
Clippy had exited with the 101 exit code
|
clippy_check
This job failure may be caused by using an out of date self-hosted runner. You are currently using runner version 2.313.0. Please update to the latest version 2.314.1
|
clippy_check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|