fix: run code quality on both push, and pull requests

[ilevyor]

code quality was not running on pull requests from third party contributors

Summary by CodeRabbit

• Chores
  • Updated the code quality workflow to trigger only for actions on the main branch.

[coderabbitai]

Walkthrough

This update narrows the scope of the automated code quality checks to be more efficient and focused. By adjusting the workflow triggers, the checks now exclusively run for activities on the main branch, streamlining the process for both push and pull_request events. This refinement ensures that resources are optimally used, focusing on the most critical branch to maintain high code quality standards.

Changes

File	Summary
.github/workflows/.../code-quality.yaml	Modified event triggers to run only on the main branch for push and pull_request events.

🐇✨
In the realm of code where the rabbits play,
A tweak was made, oh what a day!
Now only on main, the checks will dance,
Ensuring quality with every glance.
🌟📜
So hop along on this code-filled quest,
With every push and pull, we aim for the best.
🚀🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[grit-app]

On commit 2a7714d, Grit tried to heal these tests:

Job	Original Status	Final Status
code quality / clippy_check	❌ Failed	❗ Failed on attempt #3 after trying strategies ai, rerun
code quality / clippy	❌ Failed	❗ Failed on attempt #3 after trying strategies ai, rerun

Tip

You can view and edit CI healing settings on the Grit App.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 542cca3 and 2a7714d.

Files selected for processing (1)

• .github/workflows/code-quality.yaml (1 hunks)

Additional comments (3)

.github/workflows/code-quality.yaml (3)

• 3-6: The configuration to trigger the workflow on both push and pull_request events targeting the main branch is correctly implemented. This ensures that code quality checks are executed for all contributions to the main branch, whether they come from direct pushes or pull requests, including those from third-party contributors.
• 7-8: The concurrency configuration is set to ensure that only one instance of the workflow runs for a given branch or PR at a time, with newer runs cancelling in-progress ones. This is a good practice to prevent resource wastage and potential conflicts between concurrent workflow runs. However, ensure that this behavior aligns with the project's needs, as it might delay feedback for developers if many commits are pushed in quick succession.
• 1-9: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [9-20]

The clippy_check job is well-defined, with steps for cloning the code, installing dependencies, and running clippy checks. The exclusion of marzano-wasm-bindings from the checks is noted. Ensure that this exclusion is intentional and reviewed periodically, as excluding parts of the codebase from quality checks could lead to inconsistencies in code quality standards.