Skip to content

fix: run code quality on both push, and pull requests #218

fix: run code quality on both push, and pull requests

fix: run code quality on both push, and pull requests #218

GitHub Actions / clippy failed Mar 28, 2024 in 0s. View latest attempt.

clippy

3 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 3
Warning 0
Note 0
Help 0

Versions

  • rustc 1.77.0 (aedd173a2 2024-03-17)
  • cargo 1.77.0 (3fe68eabf 2024-02-29)
  • clippy 0.1.77 (aedd173 2024-03-17)

Annotations

Check failure on line 121 in crates/core/src/suppress.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

wildcard match will also match any future added variants

error: wildcard match will also match any future added variants
   --> crates/core/src/suppress.rs:121:13
    |
121 |             _ => false,
    |             ^ help: try: `EitherOrBoth::Left(_) | EitherOrBoth::Right(_)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_enum_match_arm
note: the lint level is defined here
   --> crates/core/src/lib.rs:1:9
    |
1   | #![deny(clippy::wildcard_enum_match_arm)]
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 118 in crates/core/src/suppress.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

single-character string constant used as pattern

error: single-character string constant used as pattern
   --> crates/core/src/suppress.rs:118:33
    |
118 |         .zip_longest(text.split("\n"))
    |                                 ^^^^ help: consider using a `char`: `'\n'`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
    = note: `-D clippy::single-char-pattern` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::single_char_pattern)]`

Check failure on line 554 in crates/core/src/binding.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this loop never actually loops

error: this loop never actually loops
   --> crates/core/src/binding.rs:543:25
    |
543 | /                         while !done {
544 | |                             while cursor.field_id() != Some(field_id) {
545 | |                                 if !cursor.goto_next_sibling() {
546 | |                                     return None;
...   |
553 | |                             return Some(result);
554 | |                         }
    | |_________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop
    = note: `#[deny(clippy::never_loop)]` on by default