Upgrade bindgen. #53
Upgrade bindgen. #53
Conversation
This was needed to get things compiling on Apple Silicon.
src/proj.rs
Outdated
| err = proj_errno(self.c_proj); | ||
| }, | ||
| Transformation::Projection => unsafe { | ||
| proj_errno_reset(self.c_proj); | ||
| trans = proj_trans_array(self.c_proj, inv, pj.len(), pj.as_mut_ptr()); | ||
| trans = proj_trans_array(self.c_proj, inv, pj_len, pj.as_mut_ptr()); |
There was a problem hiding this comment.
There was a problem hiding this comment.
Won't this break against our prebuilt bindings which expect a usize?
I admit - I'm kind of surprised by the changes made to bindgen.
There was a problem hiding this comment.
I suppose we can just re-generate all the prebuilt bindings with the new bindgen.
There was a problem hiding this comment.
🤦 Oh yeah, I never did #44, so we don't have any prebuilt bindings. 😅
There was a problem hiding this comment.
I admit - I'm kind of surprised by the changes made to
bindgen.
there appears to be an ongoing discussions about that change rust-lang/rust-bindgen#1901
|
Bors try |
|
Yay tests pass on CI (still not locally) |
Hrmm... could you paste the bindings.rs that are being generated and the error you're seeing? I'm super invested in the future of size_t vs. bindgen vs M1 now 😅 (reminder to self: we'll probably want to update |
Yep, it was a very sophisticated workaround… |
|
Just double checking, are there any outstanding questions here? I opted in to |
LGTM! I'm still curious as to what specific failure you were seeing on your M1 and would love to peep the bindings if you still somehow have them. |
|
bors r=michaelkirk |
I don't unfortunately :-/ |
53: Upgrade bindgen. r=michaelkirk a=frewsxcv This was needed to get things compiling on Apple Silicon. https://github.com/rust-lang/rust-bindgen/blob/master/CHANGELOG.md Co-authored-by: Corey Farwell <[email protected]>
tryTimed out. |
|
bors retry |
|
Already running a review |
|
Build failed:
|
|
huh. I reran the action and CI passed. I fear for our flapping CI. bors retry |
|
Build succeeded: |
This was needed to get things compiling on Apple Silicon.
https://github.com/rust-lang/rust-bindgen/blob/master/CHANGELOG.md