Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove size_t to usize conversion #1688

Merged
merged 1 commit into from
Dec 13, 2019
Merged

Remove size_t to usize conversion #1688

merged 1 commit into from
Dec 13, 2019

Conversation

cmcavity
Copy link
Contributor

@cmcavity cmcavity commented Dec 4, 2019

Addresses issue #1671.

emilio
emilio requested changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok, but tests need to get updated?

@cmcavity
Copy link
Contributor Author

I looked in tests/headers and it seems that in the few test headers in which size_t appears, it is just a typedef of unsigned long long or uint64_t. In that case would the tests not be affected by this change?

@emilio
Copy link
Contributor

emilio commented Dec 12, 2019

Well, you can check the travis results for yourself, they're pretty red :)

@cmcavity
Copy link
Contributor Author

r? @emilio

emilio
emilio approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good. I think we should merge this.

I'm a bit concerned about the portability of bindings for functions that use size_t... If people assume they can use the same thing across architectures.

But we can always add this back behind a runtime flag if somebody asks for it. Thank you!

@emilio emilio merged commit 5d38f2a into rust-lang:master Dec 13, 2019
@cmcavity cmcavity deleted the size_t branch December 13, 2019 22:58
@cmcavity cmcavity mentioned this pull request Jan 22, 2020
Closed
@mulark mulark mentioned this pull request Feb 11, 2020
Merged
@Cldfire Cldfire mentioned this pull request Feb 13, 2020
Merged
@dvdplm dvdplm mentioned this pull request May 5, 2020
Closed
@ngirard ngirard mentioned this pull request Dec 4, 2020
Merged
2 tasks
@frewsxcv frewsxcv mentioned this pull request Dec 9, 2020
Merged
@michaelkirk michaelkirk mentioned this pull request Dec 18, 2020
Merged
TheSven73 pushed a commit to TheSven73/linux that referenced this pull request Apr 13, 2021
rust: remove guard for rust-bindgen bug
f44deb9 
The bug which this guard protects against
(rust-lang/rust-bindgen#1671)
was fixed upstream as of rust-bindgen v0.53:
rust-lang/rust-bindgen#1688
d650823839f7 ("Remove size_t to usize conversion")

The current recommended rust-bindgen version for building
the Linux kernel is v0.56, so the guard can be safely
dropped.

Signed-off-by: Sven Van Asbroeck <[email protected]>
This was referenced Apr 13, 2021
Closed
Closed
TheSven73 pushed a commit to TheSven73/linux that referenced this pull request Apr 14, 2021
rust: remove guard for rust-bindgen bug
af7d432 
The bug which this guard protects against
(rust-lang/rust-bindgen#1671)
was fixed upstream as of rust-bindgen v0.53:
rust-lang/rust-bindgen#1688
d650823839f7 ("Remove size_t to usize conversion")

The current recommended rust-bindgen version for building
the Linux kernel is v0.56, so the guard can be safely
dropped.

Signed-off-by: Sven Van Asbroeck <[email protected]>
TheSven73 pushed a commit to TheSven73/linux that referenced this pull request Apr 14, 2021
rust: remove guard for rust-bindgen bug
47decf9 
The bug which this guard protects against
(rust-lang/rust-bindgen#1671)
was fixed upstream as of rust-bindgen v0.53:
rust-lang/rust-bindgen#1688
d650823839f7 ("Remove size_t to usize conversion")

The current recommended rust-bindgen version for building
the Linux kernel is v0.56, so the guard can be safely
dropped.

Signed-off-by: Sven Van Asbroeck <[email protected]>
TheSven73 pushed a commit to TheSven73/linux that referenced this pull request Apr 15, 2021
rust/arm 32-bit: remove guard for rust-bindgen bug
62bfa69 
On 32-bit arm, `size_t` and 'uintptr_t` are incompatible,
which will trigger the static assertion.

The bug which this guard protects against
(rust-lang/rust-bindgen#1671)
was fixed upstream as of rust-bindgen v0.53:
rust-lang/rust-bindgen#1688
d650823839f7 ("Remove size_t to usize conversion")

The current recommended rust-bindgen version for building
the Linux kernel is v0.56, so the guard can be safely
dropped.

Out of an abundance of caution, remove the guard only
if building for 32-bit arm.

Signed-off-by: Sven Van Asbroeck <[email protected]>
TheSven73 pushed a commit to TheSven73/linux that referenced this pull request Apr 15, 2021
rust/arm 32-bit: remove guard for rust-bindgen bug
04ab070 
On 32-bit arm, `size_t` and 'uintptr_t` are incompatible,
which will trigger the static assertion.

The bug which this guard protects against
(rust-lang/rust-bindgen#1671)
was fixed upstream as of rust-bindgen v0.53:
rust-lang/rust-bindgen#1688
d650823839f7 ("Remove size_t to usize conversion")

The current recommended rust-bindgen version for building
the Linux kernel is v0.56, so the guard can be safely
dropped.

Out of an abundance of caution, remove the guard only
if building for 32-bit arm.

Signed-off-by: Sven Van Asbroeck <[email protected]>
TheSven73 pushed a commit to TheSven73/linux that referenced this pull request Apr 15, 2021
rust/arm 32-bit: remove guard for rust-bindgen bug
499914e 
On 32-bit arm, `size_t` and 'uintptr_t` are incompatible,
which will trigger the static assertion.

The bug which this guard protects against
(rust-lang/rust-bindgen#1671)
was fixed upstream as of rust-bindgen v0.53:
rust-lang/rust-bindgen#1688
d650823839f7 ("Remove size_t to usize conversion")

The current recommended rust-bindgen version for building
the Linux kernel is v0.56, so the guard can be safely
dropped.

Out of an abundance of caution, remove the guard only
if building for 32-bit arm.

Signed-off-by: Sven Van Asbroeck <[email protected]>
TheSven73 pushed a commit to TheSven73/linux that referenced this pull request Apr 15, 2021
rust/arm 32-bit: remove guard for rust-bindgen bug
c54f11c 
On 32-bit arm, `size_t` and 'uintptr_t` are incompatible,
which will trigger the static assertion.

The bug which this guard protects against
(rust-lang/rust-bindgen#1671)
was fixed upstream as of rust-bindgen v0.53:
rust-lang/rust-bindgen#1688
d650823839f7 ("Remove size_t to usize conversion")

The current recommended rust-bindgen version for building
the Linux kernel is v0.56, so the guard can be safely
dropped.

Out of an abundance of caution, remove the guard only
if building for 32-bit arm.

Signed-off-by: Sven Van Asbroeck <[email protected]>
TheSven73 pushed a commit to TheSven73/linux that referenced this pull request Apr 16, 2021
rust/arm 32-bit: remove guard for rust-bindgen bug
4f98b4a 
On 32-bit arm, `size_t` and 'uintptr_t` are incompatible,
which will trigger the static assertion.

The bug which this guard protects against
(rust-lang/rust-bindgen#1671)
was fixed upstream as of rust-bindgen v0.53:
rust-lang/rust-bindgen#1688
d650823839f7 ("Remove size_t to usize conversion")

The current recommended rust-bindgen version for building
the Linux kernel is v0.56, so the guard can be safely
dropped.

Out of an abundance of caution, remove the guard only
if building for 32-bit arm.

Signed-off-by: Sven Van Asbroeck <[email protected]>
TheSven73 pushed a commit to TheSven73/linux that referenced this pull request Apr 16, 2021
rust/arm 32-bit: remove guard for rust-bindgen bug
478341d 
On 32-bit arm, `size_t` and 'uintptr_t` are incompatible,
which will trigger the static assertion.

The bug which this guard protects against
(rust-lang/rust-bindgen#1671)
was fixed upstream as of rust-bindgen v0.53:
rust-lang/rust-bindgen#1688
d650823839f7 ("Remove size_t to usize conversion")

The current recommended rust-bindgen version for building
the Linux kernel is v0.56, so the guard can be safely
dropped.

Out of an abundance of caution, remove the guard only
if building for 32-bit arm.

Signed-off-by: Sven Van Asbroeck <[email protected]>
ojeda pushed a commit to Rust-for-Linux/linux that referenced this pull request Apr 27, 2021
@ojeda
rust: helpers: remove guard for rust-bindgen bug
b5a88a2 
On 32-bit arm, `size_t` and 'uintptr_t` are incompatible,
which will trigger the static assertion.

The bug which this guard protects against
(rust-lang/rust-bindgen#1671)
was fixed upstream as of rust-bindgen v0.53:
rust-lang/rust-bindgen#1688
d650823839f7 ("Remove size_t to usize conversion")

The current recommended rust-bindgen version for building
the Linux kernel is v0.56, so the guard can be safely
dropped.

Out of an abundance of caution, remove the guard only
if building for 32-bit arm.

Signed-off-by: Sven Van Asbroeck <[email protected]>
[normalized title]
Signed-off-by: Miguel Ojeda <[email protected]>
@birkenfeld birkenfeld mentioned this pull request May 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio emilio approved these changes

Assignees

@emilio emilio

Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmcavity @emilio @highfive