-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include pre-compiled headers, bindgen only as optional feature #44
Comments
Yes! The only concern I have is around cross-platform / cross architecture interaction. Are we sure that bindgen generates the same bindings for e.g. |
I did some digging at the time, and I think there's no issue around generated types differing btw. |
Nice! Yeah, it seems common enough practice. I'll probably generate the headers on ubuntu though (maybe on the ci-docker container). It'd be nice to script, or at least document, the process. It's next on my list after #41 |
bindgen
accounts for the vast majority of the remaining deps for proj. Since they are build_dependencies they don't contribute to the size of the output binary, but it does take time to compile.It seems like a popular approach is to bake in the prebuilt bindings, but then allow the user a way to manually generate via a feature flag.
e.g. rustsqlite
bundled bindings: https://github.com/rusqlite/rusqlite/tree/master/libsqlite3-sys/bindgen-bindings
zstd
gdal
bundled bindings: https://github.com/georust/gdal/tree/master/gdal-sys/prebuilt-bindings
So achieving this would entail at least:
bindgen
feature maintains the current behavior.Would you be interested in merging such a thing?
The text was updated successfully, but these errors were encountered: