-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge 12 -> main #886
Merge 12 -> main #886
Conversation
Signed-off-by: William Lew <[email protected]>
Signed-off-by: William Lew <[email protected]>
Signed-off-by: William Lew <[email protected]>
* GitHub CI: only build pxr on 20.04 * Add comment mentioning issue #869 Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: ahcorde <[email protected]> Co-authored-by: Ashton Larkin <[email protected]>
Signed-off-by: ahcorde <[email protected]> Co-authored-by: Ashton Larkin <[email protected]>
Prepare for 12.4.0~pre1 prerelease
Signed-off-by: ahcorde <[email protected]> Co-authored-by: Ashton Larkin <[email protected]>
* enable static checkers Signed-off-by: Louise Poubel <[email protected]> * Fix focal linting errors Signed-off-by: Steve Peters <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
* Fix a lack of ParserConfig propagation. Copied from patch in RobotLocomotion/drake#16791 by jwnimmer-tri. * Pass ParserConfig to parser helper functions Require ParserConfig argument in parser.cc's private helper functions: initDoc, initXml, and _initFile. Signed-off-by: Steve Peters <[email protected]>
why do I so often target the wrong branch with forward-porting PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with happy CI
auto-merge enabled |
Codecov Report
@@ Coverage Diff @@
## main #886 +/- ##
==========================================
- Coverage 88.65% 88.16% -0.50%
==========================================
Files 92 100 +8
Lines 14222 14630 +408
==========================================
+ Hits 12608 12898 +290
- Misses 1614 1732 +118
Continue to review full report at Codecov.
|
➡️ Forward port
Port sdf12 to main
Branch comparison: main...sdf12
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)