[parsing] Stop using mutable globals #16791
Conversation
jwnimmer-tri
added
priority: medium
release notes: fix
|
+@rpoyner-tri for feature review, please. |
jwnimmer-tri
force-pushed
the
parsing-sdf-global-debung
branch
from
4caff44 to
f0fe21a
Compare
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: LGTM missing from assignee sherm1(platform) (waiting on @sherm1)
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee sherm1(platform) (waiting on @jwnimmer-tri and @sherm1)
tools/workspace/sdformat/patches/no_global_config.patch, line 3 at r1 (raw file):
Change the global singleton into a bomb. Use the default config when parsing the built-in root.sdf.
Working
I should tune up this comment slightly, before we merge this PR.
Suggestion:
Use the default config when parsing the built-in root.sdf, and in
the ign_sdf command-line tool.
jwnimmer-tri
force-pushed
the
parsing-sdf-global-debung
branch
from
f0fe21a to
8a3f931
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: LGTM missing from assignee sherm1(platform) (waiting on @sherm1)
jwnimmer-tri
force-pushed
the
parsing-sdf-global-debung
branch
from
8a3f931 to
9da5f8c
Compare
There was a problem hiding this comment.
Platform
Reviewed 1 of 5 files at r1, 1 of 1 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),sherm1(platform) (waiting on @jwnimmer-tri)
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
Copied from patch in RobotLocomotion/drake#16791 by jwnimmer-tri. Signed-off-by: Steve Peters <[email protected]>
* Fix a lack of ParserConfig propagation. Copied from patch in RobotLocomotion/drake#16791 by jwnimmer-tri. * Pass ParserConfig to parser helper functions Require ParserConfig argument in parser.cc's private helper functions: initDoc, initXml, and _initFile. Signed-off-by: Steve Peters <[email protected]>
This ensures that our parsing configuration is always what we asked for.
Towards #16784.
A related issue has been filed upstream as gazebosim/sdformat#881.
This change is