Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 12.4.0~pre1 prerelease #865

Merged

Conversation

WilliamLewww
Copy link
Contributor

🎈 Prerelease

Preparation for 12.4.0~pre1 prerelease.

Comparison to 12.3.0: sdformat12_12.3.0...sdformat12

Needed by:

Checklist

  • Asked team if this is a good time for a release
  • There are no changes to be ported from the previous major version
  • No PRs targeted at this major version are close to getting in
  • Bumped minor for new features, patch for bug fixes
  • Updated changelog
  • Updated migration guide (as needed)
  • Link to PR updating dependency versions in appropriate repository in ignition-release (as needed):

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 2, 2022
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just have some comments about cleaning up the changelog.

This release should also help with gazebosim/gz-sim#1333

Changelog.md Outdated Show resolved Hide resolved
Changelog.md Outdated Show resolved Hide resolved
Changelog.md Outdated Show resolved Hide resolved
@WilliamLewww WilliamLewww marked this pull request as draft March 2, 2022 23:00
@WilliamLewww
Copy link
Contributor Author

Converted to draft to wait for #831 functionality on pre-release.

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2022

Codecov Report

Merging #865 (091869e) into sdf12 (346f3ae) will not change coverage.
The diff coverage is n/a.

❗ Current head 091869e differs from pull request most recent head 1c2ae1f. Consider uploading reports for the commit 1c2ae1f to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##            sdf12     #865   +/-   ##
=======================================
  Coverage   88.19%   88.19%           
=======================================
  Files          95       95           
  Lines       14525    14525           
=======================================
  Hits        12811    12811           
  Misses       1714     1714           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 346f3ae...1c2ae1f. Read the comment docs.

@nkoenig
Copy link
Contributor

nkoenig commented Mar 3, 2022

Just a reminder that the next sdf12 full release should have this PR in it: #842.

@scpeters
Copy link
Member

scpeters commented Mar 4, 2022

Just a reminder that the next sdf12 full release should have this PR in it: #842.

this is just a prerelease; we'll check again before making a stable release

@nkoenig
Copy link
Contributor

nkoenig commented Mar 4, 2022

Just a reminder that the next sdf12 full release should have this PR in it: #842.

this is just a prerelease; we'll check again before making a stable release

Yup, this was just a reminder for the next full sdf12 release.

@adlarkin
Copy link
Contributor

adlarkin commented Mar 4, 2022

Converted to draft to wait for #831 functionality on pre-release.

#831 has been merged, and I also just realized that we aren't releasing binaries for the USD component yet, so feel free to make the pre-release whenever it's needed 👍

@WilliamLewww WilliamLewww marked this pull request as ready for review March 4, 2022 20:26
@nkoenig nkoenig requested a review from scpeters March 8, 2022 18:40
@WilliamLewww WilliamLewww merged commit 81a3698 into gazebosim:sdf12 Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants