Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed some test - sdf::JointAxis is normalized and some other timers. #314

Merged
merged 6 commits into from
Sep 5, 2020
Merged

Fixed some test - sdf::JointAxis is normalized and some other timers. #314

merged 6 commits into from
Sep 5, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 26, 2020

Signed-off-by: ahcorde [email protected]

@ahcorde
Fixed some test
9b13c69 
Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde added enhancement New feature or request 🔮 dome Ignition Dome tests Broken or missing tests / testing infra labels Aug 26, 2020
@ahcorde ahcorde requested a review from chapulina as a code owner August 26, 2020 14:34
@ahcorde ahcorde self-assigned this Aug 26, 2020
@ahcorde
Copy link
Contributor Author

ahcorde commented Aug 26, 2020

The SDF converter test is failing because it's saving the URI in both formats file and URL. I thought this was fixed here gazebosim/gz-fuel-tools#85

21:       <visual name='visual'>
21:         <geometry>
21:           <mesh>
21:             <uri>file:///root/.ignition/fuel/fuel.ignitionrobotics.org/openrobotics/models/Backpack/1/https://fuel.ignitionrobotics.org/1.0/openrobotics/models/Backpack/1/files/meshes/Backpack.dae</uri>
21:           </mesh>
21:         </geometry>

@ahcorde
Copy link
Contributor Author

ahcorde commented Aug 27, 2020

I checked that there are some common parts with this other PR https://github.com/ignitionrobotics/ign-gazebo/pull/288/files

  • This PR fix another compilation warning dda96b0
  • Some other tests

@scpeters
Copy link
Member

@osrf-jenkins run tests please

1 similar comment
@scpeters
Copy link
Member

@osrf-jenkins run tests please

@scpeters
Copy link
Member

scpeters commented Sep 1, 2020

The SDF converter test is failing because it's saving the URI in both formats file and URL. I thought this was fixed here ignitionrobotics/ign-fuel-tools#85

21:       <visual name='visual'>
21:         <geometry>
21:           <mesh>
21:             <uri>file:///root/.ignition/fuel/fuel.ignitionrobotics.org/openrobotics/models/Backpack/1/https://fuel.ignitionrobotics.org/1.0/openrobotics/models/Backpack/1/files/meshes/Backpack.dae</uri>
21:           </mesh>
21:         </geometry>

I created an issue for this: #322

@scpeters scpeters mentioned this pull request Sep 1, 2020
Closed
@chapulina
Copy link
Contributor

The joint axis failures should be fixed since #288

@codecov
Copy link

codecov bot commented Sep 5, 2020 •
edited
Loading

Codecov Report

Merging #314 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   77.19%   77.19%           
=======================================
  Files         200      200           
  Lines       10641    10641           
=======================================
  Hits         8214     8214           
  Misses       2427     2427
Impacted Files Coverage Δ
src/EntityComponentManager.cc 85.38% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f5f2d0...dbefcd6. Read the comment docs.

@chapulina chapulina merged commit 375d626 into master Sep 5, 2020
@chapulina chapulina deleted the ahcorde/fix/test branch September 5, 2020 16:18
chapulina added a commit that referenced this pull request Oct 21, 2020
@chapulina
Revert diff_drive test changes from #314 (#410)
0ab6d35 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina mentioned this pull request Oct 21, 2020
Merged
chapulina pushed a commit that referenced this pull request Jul 23, 2021
@ahcorde @chapulina
Make some tests more robust (#314)
c570ecd 
Signed-off-by: ahcorde <[email protected]>
chapulina pushed a commit that referenced this pull request Jul 23, 2021
@ahcorde @chapulina
Make some tests more robust (#314)
a8894e9 
Signed-off-by: ahcorde <[email protected]>

Removed changes to diff-drive command when backporting to ign-gazebo3

Signed-off-by: Louise Poubel <[email protected]>
chapulina pushed a commit that referenced this pull request Jul 23, 2021
@ahcorde @chapulina
Make some tests more robust (#314)
dd608ca 
Signed-off-by: ahcorde <[email protected]>

Removed changes to diff-drive command when backporting to ign-gazebo3

Signed-off-by: Louise Poubel <[email protected]>
blakermchale pushed a commit to blakermchale/ign-gazebo that referenced this pull request Aug 15, 2021
@ahcorde @blakermchale
Make some tests more robust (gazebosim#314)
94024cf 
Signed-off-by: ahcorde <[email protected]>

Removed changes to diff-drive command when backporting to ign-gazebo3

Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Blake McHale <[email protected]>
@iche033 iche033 mentioned this pull request Oct 22, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees

@ahcorde ahcorde

Labels
🔮 dome Ignition Dome enhancement New feature or request tests Broken or missing tests / testing infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahcorde @scpeters @chapulina