Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 to 5 20220401 #335

Merged
merged 7 commits into from
Apr 1, 2022
Merged

4 to 5 20220401 #335

merged 7 commits into from
Apr 1, 2022

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Apr 1, 2022

➡️ Forward port

Port ign-common4 to main

Branch comparison: main...ign-common4

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

@nkoenig nkoenig requested a review from mjcarroll as a code owner April 1, 2022 12:11
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 1, 2022
@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #335 (831924d) into main (d266053) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #335   +/-   ##
=======================================
  Coverage   77.13%   77.13%           
=======================================
  Files          76       76           
  Lines       10540    10540           
=======================================
  Hits         8130     8130           
  Misses       2410     2410           
Impacted Files Coverage Δ
src/Console.cc 85.71% <100.00%> (ø)
src/URI.cc 97.13% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d266053...831924d. Read the comment docs.

@nkoenig nkoenig merged commit f50d514 into main Apr 1, 2022
@nkoenig nkoenig deleted the 4-to-5-20220401 branch April 1, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants