Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignLogInit failing if run after console output #332

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Mar 31, 2022

Signed-off-by: Nate Koenig [email protected]

🦟 Bug fix

Fixes #331

Summary

Use Console:log() in Console.cc in order to support execution of the ignLogInit function after console out has occured.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig requested a review from mjcarroll as a code owner March 31, 2022 20:40
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Mar 31, 2022
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #332 (3731eda) into ign-common3 (429fbc6) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           ign-common3     #332   +/-   ##
============================================
  Coverage        76.58%   76.58%           
============================================
  Files               73       73           
  Lines            10403    10403           
============================================
  Hits              7967     7967           
  Misses            2436     2436           
Impacted Files Coverage Δ
src/Console.cc 84.80% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 429fbc6...3731eda. Read the comment docs.

@nkoenig nkoenig merged commit 9334192 into ign-common3 Mar 31, 2022
@nkoenig nkoenig deleted the console_log_init_fix branch March 31, 2022 23:35
@chapulina
Copy link
Contributor

⚠️ Let's remember to squash-merge, as written on the PR description. This PR ended up as 2 commits on the history, one of which isn't signed, and neither have the correct formatting for changelog generation.

https://github.com/ignitionrobotics/ign-common/commits/ign-common3

@chapulina chapulina changed the title Fix issue 331 Fix ignLogInit failing if run after console output Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants