Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 to 4 20220331 #334

Merged
merged 3 commits into from
Apr 1, 2022
Merged

3 to 4 20220331 #334

merged 3 commits into from
Apr 1, 2022

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Mar 31, 2022

➡️ Forward port

Port ign-common3 to ign-common4

Branch comparison: https://github.com/ignitionrobotics/ign-common/compare/ign-common4...ign-common3?expand=1

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

@nkoenig nkoenig requested a review from mjcarroll as a code owner March 31, 2022 23:37
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress labels Mar 31, 2022
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #334 (b9bb793) into ign-common4 (c0d7e6c) will not change coverage.
The diff coverage is 100.00%.

❗ Current head b9bb793 differs from pull request most recent head a0433ab. Consider uploading reports for the commit a0433ab to get more accurate results

@@             Coverage Diff              @@
##           ign-common4     #334   +/-   ##
============================================
  Coverage        77.02%   77.02%           
============================================
  Files               76       76           
  Lines            10729    10729           
============================================
  Hits              8264     8264           
  Misses            2465     2465           
Impacted Files Coverage Δ
src/Console.cc 86.13% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0d7e6c...a0433ab. Read the comment docs.

@nkoenig nkoenig merged commit d7266a3 into ign-common4 Apr 1, 2022
@nkoenig nkoenig deleted the 3-to-4-20220331 branch April 1, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants