Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gzdev repository enable from GZDEV_USE_* files #65

Draft
wants to merge 3 commits into
base: focal
Choose a base branch
from

Conversation

scpeters
Copy link
Contributor

Initial attempt at gazebo-tooling/gzdev#65. Enable nightly / prerelease repository if .github/ci/GZDEV_USE_NIGHTLY or .github/ci/GZDEV_USE_PRERELEASE files are present. Needs testing.

Do we like GZDEV_USE_*? An alternative is to match the gzdev.py repository enable osrf nightly syntax like GZDEV_ENABLE_OSRF_NIGHTLY

Signed-off-by: Steve Peters <[email protected]>
Run `gzdev repository enable osrf {nightly|prerelease}`
if the .github/ci folder contains a matching
GZDEV_USE_* file.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from j-rivero December 20, 2022 10:33
@scpeters scpeters changed the title Scpeters/gzdev files focal gzdev repository enable from GZDEV_USE_* files Dec 20, 2022
@j-rivero
Copy link
Contributor

j-rivero commented Dec 21, 2022

Ouch sorry, the comments were more for changes in gzdev itself and this is modifying the code of CI on actions.

We probably want a solution that can be applied to both github actions and Jenkins, maybe better to change gzdev code itself to do the same for both?

Thanks for PR, I think it is a good starting point. Some thoughts before going forward:

* Where in the filesystem gzdev will look for the special configuration files? In an absolute path? Somewhere with respect to its current location?

* If there is a call to gzdev like gzdev.py repository enable --project=gz-math7, the configuration using the file is added to the existing in the central repo or the configuration is overridden?

Do we like GZDEV_USE_*? An alternative is to match the gzdev.py repository enable osrf nightly syntax like GZDEV_ENABLE_OSRF_NIGHTLY

Thinking on reuse this kind of files and given that the parameters to enable/disable repositories without declaring --project are positionals, we could try to split words and use them as parameters: GZDEV_WORD1_WORD2_WORD3 to do the same that gzdev word1 word2 word3 cli call. GZDEV_REPOSITORY_ENABLE_OSRF_NIGHTLY to be transformed by gzdev repository enable osrf nightly. Depending on the different gzdev modules we might want to restrict this to the repository module by now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants