-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the process of using prereleases for testing in a PR #65
Comments
I think it would be easy enough to add a |
If it's safe to use all prereleases or all nightlies, as opposed to just the relevant ones for the PR, then what @scpeters recommended is much easier. With either of the approaches, I'd suggest we create some sort of merge protection rule to prevent accidental merging while these files are present. One way would be to create a github action job that fails if any of these files are present and making that a required job for merge. |
we don't currently have a mechanism to specify which dependencies should be installed from stable / prerelease / nightly. For a given project, you are just able to select which sources on packages.osrfoundation.org it can install from. The gzdev plugins/config/repository.yaml file is a centralized collection of configurations for different packages, and the |
this is a good idea |
initial prototype in gazebo-tooling/action-gz-ci#65 |
Elaborating a bit more on the general context of the proposed feature:
A more complicated idea to add to the option of adding "overlays" configuration yaml or having custom files in some expected places could be to tell to projects:
- name: sdformat12
depends:
- debname: libignition-math7-dev
version: 7.1.0 and leave the tool to detect with repo is needed. I don't think that we want this since the control of dependencies in the stable repository is a highest goal probably so we would require explicit repository control. |
Currently, we have to create a PR against
gzdev
in order to use prereleases for the libraries needed by the PR. It would be nice ifgzdev
could also read a file in the root of the library repo (e.g.,gz-sim/.ci/repository.yaml
) with a similar format asrepository.yaml
and merge that with its ownrepository.yaml
giving precedence to the settings found in the library repo. For example, if I want to use a prerelease of sdformat12 for testing my gz-sim PR, I would just addin
gz-sim/.ci/repository.yaml
. Once the PR is tested with the prerelease, we would make a stable release of sdformat and remove this file from the PR.This is just a suggestion. I'm open to other ideas to make it easier to do testing with prereleases. Ideally, it would be something that would be included/modified in the PR we're testing, not in
gzdev
or elsewhere.The text was updated successfully, but these errors were encountered: