-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to [email protected] #129
Conversation
Test results: #131 (comment) |
Hi @gaurav-nelson! Per your request, I gathered some test results suggesting that this change should be an improvement. Is there anything further I can do to help this PR get merged? |
@gaurav-nelson what can we do to have this merged |
This PR works around two issues causing the markdown link check to fail in CI. 1. actions/checkout#760. A git permissions issue, apparently triggered by a combination of a git change and the behaviour of actions/checkout. 2. gaurav-nelson/github-action-markdown-link-check#129. Merging an updated version of the underlying package that fixes a bug in the handling of local #anchors. The workaround is a temporary patched fork of the link-checker action. This should be removed once the upstream issues are addressed.
This PR works around two issues causing the markdown link check to fail in CI. 1. actions/checkout#760. A git permissions issue, apparently triggered by a combination of a git change and the behaviour of actions/checkout. 2. gaurav-nelson/github-action-markdown-link-check#129. Merging an updated version of the underlying package that fixes a bug in the handling of local #anchors. The workaround is a temporary patched fork of the link-checker action. This should be removed once the upstream issues are addressed.
Work around two issues causing the markdown link check to fail in CI. 1. actions/checkout#760. A git permissions issue, apparently triggered by a combination of a git change and the behaviour of actions/checkout. 2. gaurav-nelson/github-action-markdown-link-check#129. Merging an updated version of the underlying package that fixes a bug in the handling of local #anchors. The workaround is a temporary patched fork of the link-checker action. This should be removed once the upstream issues are addressed.
@creachadair after update the change, there are still some reference links marked as dead, but actually, they can be access, please see the log for more detail |
Perhaps, but note that the results are considerably better with the newer version. The problem with the links is in the underlying link check library, not in the GitHub action. (Neither is mine, by the way, I'm just another user) |
I still see some anchors not handled properly PS:tcort/markdown-link-check#91 (comment) and tcort/markdown-link-check#195 Additionally, I would like to have an option for users to enable or disable it tcort/markdown-link-check#196 |
Yes, there still do seem to be some problems. However, v3.10.0 is a considerable improvement over the previous version, so it might be worthwhile to update anyway. |
Thank you #144 superseeds this. |
No description provided.