Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update markdown-lint-check to v3.10.0. #131

Closed
wants to merge 1 commit into from
Closed

Update markdown-lint-check to v3.10.0. #131

wants to merge 1 commit into from

Conversation

creachadair
Copy link
Contributor

This version includes a fix for #anchor links.
See tcort/markdown-link-check#91.

This version includes a fix for #anchor links.
See tcort/markdown-link-check#91.
@creachadair
Copy link
Contributor Author

Hi, @gaurav-nelson! I realized after creating this PR that someone else already has one open to do the same thing (cf. #129). Is there anything I can do to help test this change?

@gaurav-nelson
Copy link
Owner

Thank you @creachadair I guess I'll have to close this one and use #129 as it was the first one. Last time when I upgraded to 3.9.3 (#126) I received a bit of issues. PS: #127

So this time I want to check fork and test those repos locally, before merging and releasing. You can definitely help by maybe:

  • Cloning those repos locally and checking the output with the updated MLC version.
  • Paste the output in gist and comment on 129 with link to gist.

Let me know if you can help with that.

@creachadair
Copy link
Contributor Author

So this time I want to check fork and test those repos locally, before merging and releasing.

Makes sense. I'll give this a try and post a note here when I've got some data to show.

Thanks!

@creachadair creachadair deleted the mjf/bump-version branch April 7, 2022 04:22
@creachadair
Copy link
Contributor Author

creachadair commented Apr 7, 2022

Per the above, I did a before/after test, and the results are below. In short, this patch appears to fix the primary issue with #anchor links.

Repro Outline

  1. Fork the target repository and enable actions.
  2. Edit the link-checker actions config to use 1.0.14.
  3. Run the action and verify that errors similar to those reported occur.
  4. Edit the link-checker actions config to use a patch targeting v3.10.0.
  5. Run the action and verify that those errors are absent.

To effect the patch in step (4), I forked this repository and applied the diff from this PR, then updated the actions config to point to my fork instead of the real one.

Result

Errors before patch: 408
Errors after patch: 32

@creachadair
Copy link
Contributor Author

Hi @gaurav-nelson, I wanted to check back in whether there are any further data you'd like to see before you'd feel comfortable merging the update in #129.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants