-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken link detected by CI #153
Comments
This link does work, and it seems syntactically correct/the only way. 🤔 |
Debugging, this is what I have so far. It broke when we upgraded from 228fbf4ffb2a86a65314866e9b2322b519fd885f to 4d97ad89bbb0de4be573a9d7a2fc0ce900afc519. https://github.com/submariner-io/enhancements/actions?query=workflow%3APeriodic There are not any code changes to the GHA between those versions, only docs changes and a bump of the underlying linter: gaurav-nelson/github-action-markdown-link-check@228fbf4...4d97ad8 The linter was bumped from 3.8.7 to 3.10.2: gaurav-nelson/github-action-markdown-link-check@ca705e7 Other people seem to have similar issues after the bump: tcort/markdown-link-check#91 (comment) The upstream lib reported a bug/added a UT for HTML anchors in tcort/markdown-link-check#193, which is what we hit in submariner-io/submariner-website#881. That's tracked by tcort/markdown-link-check#195, which isn't fixed. But I don't think that's the same issue as we're hitting here or the comments above describe. I feel like I may be missing something obvious, or this is a timeout/rate-limit with a wrong HTTP error code. It's nuts that very similar links work.
|
Maybe let's just revert back to 228fbf4ffb2a86a65314866e9b2322b519fd885f. |
See submariner-io#153 for details. Signed-off-by: Daniel Farrell <[email protected]>
See #153 for details. Signed-off-by: Daniel Farrell <[email protected]>
See submariner-io#153 for details. Fixes: submariner-io#165 Signed-off-by: Daniel Farrell <[email protected]>
See #153 for details. Fixes: #165 Signed-off-by: Daniel Farrell <[email protected]>
Periodic link aliveness CI detected a broken link. Please see the periodic job
results for details.
The text was updated successfully, but these errors were encountered: