Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link detected by CI #153

Closed
github-actions bot opened this issue Jan 1, 2023 · 3 comments · Fixed by #160
Closed

Broken link detected by CI #153

github-actions bot opened this issue Jan 1, 2023 · 3 comments · Fixed by #160

Comments

@github-actions
Copy link

github-actions bot commented Jan 1, 2023

Periodic link aliveness CI detected a broken link. Please see the periodic job
results
for details.

@dfarrell07
Copy link
Member

This link does work, and it seems syntactically correct/the only way. 🤔

@dfarrell07
Copy link
Member

dfarrell07 commented Jan 17, 2023

Debugging, this is what I have so far.

It broke when we upgraded from 228fbf4ffb2a86a65314866e9b2322b519fd885f to 4d97ad89bbb0de4be573a9d7a2fc0ce900afc519.

https://github.com/submariner-io/enhancements/actions?query=workflow%3APeriodic

There are not any code changes to the GHA between those versions, only docs changes and a bump of the underlying linter:

gaurav-nelson/github-action-markdown-link-check@228fbf4...4d97ad8

The linter was bumped from 3.8.7 to 3.10.2:

gaurav-nelson/github-action-markdown-link-check@ca705e7

Other people seem to have similar issues after the bump:

tcort/markdown-link-check#91 (comment)
gaurav-nelson/github-action-markdown-link-check#129 (comment)

The upstream lib reported a bug/added a UT for HTML anchors in tcort/markdown-link-check#193, which is what we hit in submariner-io/submariner-website#881. That's tracked by tcort/markdown-link-check#195, which isn't fixed. But I don't think that's the same issue as we're hitting here or the comments above describe.

I feel like I may be missing something obvious, or this is a timeout/rate-limit with a wrong HTTP error code. It's nuts that very similar links work.

### Multiple Active Gateway Packet Flow with Globalnet
[Multiple Active Gateway Packet Flow with Globalnet](#multiple-active-gateway-packet-flow-with-globalnet)
[✖] #multiple-active-gateway-packet-flow-with-globalnet → Status: 404
### Multiple Active Gateway Packet Flow without Globalnet
[Multiple Active Gateway Packet Flow without Globalnet](#multiple-active-gateway-packet-flow-without-globalnet)
[✓] #multiple-active-gateway-packet-flow-without-globalnet

@dfarrell07
Copy link
Member

Maybe let's just revert back to 228fbf4ffb2a86a65314866e9b2322b519fd885f.

dfarrell07 added a commit to dfarrell07/enhancements that referenced this issue Jan 31, 2023
@dfarrell07 dfarrell07 linked a pull request Jan 31, 2023 that will close this issue
tpantelis pushed a commit that referenced this issue Jan 31, 2023
See #153 for details.

Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07 added a commit to dfarrell07/enhancements that referenced this issue Apr 12, 2023
tpantelis pushed a commit that referenced this issue Apr 13, 2023
See #153 for details.

Fixes: #165
Signed-off-by: Daniel Farrell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant