-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/starter sidebar scroll #8743
Fix/starter sidebar scroll #8743
Conversation
@LekoArts feedback welcome! thanks for noting this earlier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the gif (didn’t test it locally) it’s how I wanted to solve it — so yeah, LGTM 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Yeah, I have to admit I also was annoyed by the jumping :/
I'm not super happy about the initial unused whitespace when no filters are set. I personally wouldn't mind for the "Reset filters" button to show at the bottom of the sidebar, but moving it into the header
— next to "x Gatsby Starters (filtered)" — might be the better alternative.
@fk if it showed up at the bottom of the sidebar we'd have to reserve space at the bottom in order for the "jump" not to happen. We'd have the same problem in a different place. I'm personally a fan of this option, because at least it's visually consistent with the header in the main area on the right. Glad we could semi-resolve something that had been bothering all of us! 😹 |
True…d'oh (Homer Simpson voice) ;-) … wondering now why I subconciously implied that the other jump wouldn't be as bad :-D :-/
💯 |
Related to @LekoArts observation about the sidebar filters on starter library. (Had been bothering me too).